[java-oidc-common] branch main updated: Remove acr_values from authn request object JWT. Should be inside JWT

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-oidc-common.

View the commit online:
http://git.shibboleth.net/view/?p=java-oidc-common.git;a=commit;h=3b08dc96d833292e16f12aa12d25c99b2450e82e

The following commit(s) were added to refs/heads/main by this push:
     new 3b08dc9  Remove acr_values from authn request object JWT. Should be inside JWT
3b08dc9 is described below

commit 3b08dc96d833292e16f12aa12d25c99b2450e82e
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Tue Jan 3 09:50:29 2023 +0000

    Remove acr_values from authn request object JWT. Should be inside JWT
---
 .../profile/encoding/impl/AbstractOIDCMessageEncoder.java    | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/encoding/impl/AbstractOIDCMessageEncoder.java b/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/encoding/impl/AbstractOIDCMessageEncoder.java
index a618595..3fac2d4 100644
--- a/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/encoding/impl/AbstractOIDCMessageEncoder.java
+++ b/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/encoding/impl/AbstractOIDCMessageEncoder.java
@@ -168,17 +168,7 @@ public abstract class AbstractOIDCMessageEncoder extends AbstractHttpServletResp
                 throw new MessageEncodingException("Couldn't serialize request object to JWT: " + e.getMessage(), e);
             }
         }      
-        
-        // Only add ACR values as acr_values if the provider does not support the 'claims' claim. Hence is not contained
-        // inside the request object
-        if (!req.providerSupportsClaimsParameter() && !req.getAcrs().isEmpty()) {  
-            final String acrString =String.join(" ", req.getAcrs()
-                    .stream()
-                    .map(ACR::getValue)
-                    .collect(Collectors.toUnmodifiableList()));
-            params.add(new Pair<>("acr_values", acrString));          
-        }
-        
+
         if (!validateParams(params)) {            
             throw new MessageEncodingException("Authorization parameters are not valid");
         }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.