[java-shib-profile] branch main updated: Tweak some javadoc and remove redundant public qualifiers.
Scott Cantor
cantor.2 at osu.edu
Wed Feb 22 15:13:12 UTC 2023
This is an automated email from the git hooks/post-receive script.
scantor pushed a commit to branch main
in repository java-shib-profile.
View the commit online:
http://git.shibboleth.net/view/?p=java-shib-profile.git;a=commit;h=f8a5989893846f04cad900b8c235238bd517cd6f
The following commit(s) were added to refs/heads/main by this push:
new f8a5989 Tweak some javadoc and remove redundant public qualifiers.
f8a5989 is described below
commit f8a5989893846f04cad900b8c235238bd517cd6f
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Feb 22 10:13:09 2023 -0500
Tweak some javadoc and remove redundant public qualifiers.
---
.../saml/profile/config/BasicSAMLArtifactConfiguration.java | 7 ++-----
.../config/ArtifactResolutionProfileConfiguration.java | 2 +-
.../profile/config/AttributeQueryProfileConfiguration.java | 3 +--
.../saml1/profile/config/BrowserSSOProfileConfiguration.java | 2 +-
.../config/ArtifactResolutionProfileConfiguration.java | 2 +-
.../profile/config/AttributeQueryProfileConfiguration.java | 3 +--
.../saml2/profile/config/BrowserSSOProfileConfiguration.java | 12 ++++++------
.../saml/saml2/profile/config/ECPProfileConfiguration.java | 2 +-
.../profile/config/SingleLogoutProfileConfiguration.java | 2 +-
9 files changed, 15 insertions(+), 20 deletions(-)
diff --git a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/profile/config/BasicSAMLArtifactConfiguration.java b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/profile/config/BasicSAMLArtifactConfiguration.java
index 8975f1f..89ba53f 100644
--- a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/profile/config/BasicSAMLArtifactConfiguration.java
+++ b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/profile/config/BasicSAMLArtifactConfiguration.java
@@ -25,9 +25,9 @@ import net.shibboleth.shared.logic.ConstraintViolationException;
import net.shibboleth.shared.primitive.StringSupport;
/**
- * Interface for outbound SAML artifact configuration.
+ * Concrete class for outbound SAML artifact configuration.
*
- * <p>While sufficient for known SAML 1 and 2 artifact types, the interface
+ * <p>While sufficient for known SAML 1 and 2 artifact types, the class
* may be extended if necessary to carry type-specific additions.</p>
*/
public class BasicSAMLArtifactConfiguration implements SAMLArtifactConfiguration {
@@ -42,7 +42,6 @@ public class BasicSAMLArtifactConfiguration implements SAMLArtifactConfiguration
@Nullable private Integer artifactResolutionIndex;
/** {@inheritDoc} */
- @Override
@Nullable public byte[] getArtifactType() {
return artifactType;
}
@@ -71,7 +70,6 @@ public class BasicSAMLArtifactConfiguration implements SAMLArtifactConfiguration
}
/** {@inheritDoc} */
- @Override
@Nullable public String getArtifactResolutionServiceURL() {
return artifactResolutionURL;
}
@@ -86,7 +84,6 @@ public class BasicSAMLArtifactConfiguration implements SAMLArtifactConfiguration
}
/** {@inheritDoc} */
- @Override
@Nullable public Integer getArtifactResolutionServiceIndex() {
return artifactResolutionIndex;
}
diff --git a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml1/profile/config/ArtifactResolutionProfileConfiguration.java b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml1/profile/config/ArtifactResolutionProfileConfiguration.java
index ad2dfb4..3d03339 100644
--- a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml1/profile/config/ArtifactResolutionProfileConfiguration.java
+++ b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml1/profile/config/ArtifactResolutionProfileConfiguration.java
@@ -29,7 +29,7 @@ import net.shibboleth.shared.annotation.constraint.NotEmpty;
public interface ArtifactResolutionProfileConfiguration extends SAMLProfileConfiguration {
/** ID for this profile configuration. */
- @Nonnull @NotEmpty public static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml1/query/artifact";
+ @Nonnull @NotEmpty static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml1/query/artifact";
/**
* Get whether enclosed assertions should be signed.
diff --git a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml1/profile/config/AttributeQueryProfileConfiguration.java b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml1/profile/config/AttributeQueryProfileConfiguration.java
index 07638c7..33aa495 100644
--- a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml1/profile/config/AttributeQueryProfileConfiguration.java
+++ b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml1/profile/config/AttributeQueryProfileConfiguration.java
@@ -31,7 +31,6 @@ import net.shibboleth.shared.annotation.constraint.NotEmpty;
public interface AttributeQueryProfileConfiguration extends SAMLProfileConfiguration {
/** ID for this profile configuration. */
- @Nonnull @NotEmpty
- public static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml1/query/attribute";
+ @Nonnull @NotEmpty static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml1/query/attribute";
}
\ No newline at end of file
diff --git a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml1/profile/config/BrowserSSOProfileConfiguration.java b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml1/profile/config/BrowserSSOProfileConfiguration.java
index 850a818..76d0e03 100644
--- a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml1/profile/config/BrowserSSOProfileConfiguration.java
+++ b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml1/profile/config/BrowserSSOProfileConfiguration.java
@@ -26,6 +26,6 @@ import net.shibboleth.shared.annotation.constraint.NotEmpty;
public interface BrowserSSOProfileConfiguration extends SAMLProfileConfiguration {
/** ID for this profile configuration. */
- @Nonnull @NotEmpty public static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml1/sso/browser";
+ @Nonnull @NotEmpty static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml1/sso/browser";
}
\ No newline at end of file
diff --git a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/ArtifactResolutionProfileConfiguration.java b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/ArtifactResolutionProfileConfiguration.java
index a726d5e..0aa9737 100644
--- a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/ArtifactResolutionProfileConfiguration.java
+++ b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/ArtifactResolutionProfileConfiguration.java
@@ -28,7 +28,7 @@ import net.shibboleth.shared.annotation.constraint.NotEmpty;
public interface ArtifactResolutionProfileConfiguration extends SAML2ProfileConfiguration {
/** ID for this profile configuration. */
- @Nonnull @NotEmpty public static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml2/query/artifact";
+ @Nonnull @NotEmpty static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml2/query/artifact";
/**
* Gets whether enclosed assertions should be signed.
diff --git a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/AttributeQueryProfileConfiguration.java b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/AttributeQueryProfileConfiguration.java
index eac242f..55dd56d 100644
--- a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/AttributeQueryProfileConfiguration.java
+++ b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/AttributeQueryProfileConfiguration.java
@@ -30,7 +30,6 @@ import net.shibboleth.shared.annotation.constraint.NotEmpty;
public interface AttributeQueryProfileConfiguration extends SAML2ProfileConfiguration {
/** ID for this profile configuration. */
- @Nonnull @NotEmpty
- public static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml2/query/attribute";
+ @Nonnull @NotEmpty static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml2/query/attribute";
}
\ No newline at end of file
diff --git a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/BrowserSSOProfileConfiguration.java b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/BrowserSSOProfileConfiguration.java
index a9727ed..11c97b2 100644
--- a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/BrowserSSOProfileConfiguration.java
+++ b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/BrowserSSOProfileConfiguration.java
@@ -46,22 +46,22 @@ public interface BrowserSSOProfileConfiguration extends SAMLArtifactConsumerProf
SAML2ProfileConfiguration, SAMLAssertionConsumingProfileConfiguration {
/** ID for this profile configuration. */
- @Nonnull @NotEmpty public static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml2/sso/browser";
+ @Nonnull @NotEmpty static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml2/sso/browser";
/** Bit constant for RequestedAuthnContext feature. */
- public static final int FEATURE_AUTHNCONTEXT = 0x1;
+ static final int FEATURE_AUTHNCONTEXT = 0x1;
/** Bit constant for Scoping feature. */
- public static final int FEATURE_SCOPING = 0x2;
+ static final int FEATURE_SCOPING = 0x2;
/** Bit constant for NameIDPolicy Format feature. */
- public static final int FEATURE_NAMEIDFORMAT = 0x4;
+ static final int FEATURE_NAMEIDFORMAT = 0x4;
/** Bit constant for NameIDPolicy SPNameQualifier feature. */
- public static final int FEATURE_SPNAMEQUALIFIER = 0x8;
+ static final int FEATURE_SPNAMEQUALIFIER = 0x8;
/** Bit constant for ForceAuthn feature. */
- public static final int FEATURE_FORCEAUTHN = 0x10;
+ static final int FEATURE_FORCEAUTHN = 0x10;
/**
* Get whether a fresh user presence proof should be required for this request.
diff --git a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/ECPProfileConfiguration.java b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/ECPProfileConfiguration.java
index 7d2f8d7..e569b06 100644
--- a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/ECPProfileConfiguration.java
+++ b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/ECPProfileConfiguration.java
@@ -25,6 +25,6 @@ import net.shibboleth.shared.annotation.constraint.NotEmpty;
public interface ECPProfileConfiguration extends BrowserSSOProfileConfiguration {
/** ID for this profile configuration. */
- @Nonnull @NotEmpty public static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml2/sso/ecp";
+ @Nonnull @NotEmpty static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml2/sso/ecp";
}
\ No newline at end of file
diff --git a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/SingleLogoutProfileConfiguration.java b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/SingleLogoutProfileConfiguration.java
index 497808d..c8a8cc1 100644
--- a/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/SingleLogoutProfileConfiguration.java
+++ b/shib-saml-profile-api/src/main/java/net/shibboleth/saml/saml2/profile/config/SingleLogoutProfileConfiguration.java
@@ -35,7 +35,7 @@ public interface SingleLogoutProfileConfiguration extends SAML2ProfileConfigurat
SAMLArtifactConsumerProfileConfiguration {
/** ID for this profile configuration. */
- @Nonnull @NotEmpty public static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml2/logout";
+ @Nonnull @NotEmpty static final String PROFILE_ID = "http://shibboleth.net/ns/profiles/saml2/logout";
/**
* Get whether SOAP-based requests should be signed.
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list