[JIRA] (IDP-2074) Audit logging of chained password validators is broken

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-2074 ( https://shibboleth.atlassian.net/browse/IDP-2074?atlOrigin=eyJpIjoiZjgxYTkyZTE1Mzk0NDYzMWE0M2FiZDM5NGNmMTJjMzIiLCJwIjoiaiJ9 )

Re: Audit logging of chained password validators is broken ( https://shibboleth.atlassian.net/browse/IDP-2074?atlOrigin=eyJpIjoiZjgxYTkyZTE1Mzk0NDYzMWE0M2FiZDM5NGNmMTJjMzIiLCJwIjoiaiJ9 )

The problem is the usual “success is a null” combined with the fact that the error tracking by design tracks all events signaled by all the validators so that the error view can prioritize which one to treat as definitive for the user.

In part the solution is going to probably be to pull the audit extractor I built to output the result and do it inline inside the AbstractAuditingValidationAction class if that doesn’t break everything else. That could allow it to incorporate the knowledge of whether recording success or failure triggered the audit but that will still leave the problem of it logging “all” the failure events it has accumulated. But success would probably be fixed.

Possibly I could fix it by adjusting the underlying class that’s storing the events in the error context so that the last one added is known via an ordered collection.

( https://shibboleth.atlassian.net/browse/IDP-2074#add-comment?atlOrigin=eyJpIjoiZjgxYTkyZTE1Mzk0NDYzMWE0M2FiZDM5NGNmMTJjMzIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2074#add-comment?atlOrigin=eyJpIjoiZjgxYTkyZTE1Mzk0NDYzMWE0M2FiZDM5NGNmMTJjMzIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100216- sha1:64a4cf6 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230221/13e67733/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-fc58f5c0-b995-4f31-88da-d9c3b8c7d351
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230221/13e67733/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-71dc6419-3515-42a7-9db0-aae481385a8b
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230221/13e67733/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-3562f538-bc1d-4418-93ec-0a578be7707b
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230221/13e67733/attachment-0005.png>