[java-idp-plugin-oidc-rp] branch main updated: Fix tests

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=3a0686a3464bfce85eae51a60a39a9b3f2d0ed48

The following commit(s) were added to refs/heads/main by this push:
     new 3a0686a  Fix tests
3a0686a is described below

commit 3a0686a3464bfce85eae51a60a39a9b3f2d0ed48
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Mon Feb 20 15:27:12 2023 +0000

    Fix tests
---
 ...yingPartyProxySigningParametersResolverTest.java | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/RelyingPartyProxySigningParametersResolverTest.java b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/RelyingPartyProxySigningParametersResolverTest.java
index 0b9d740..aa0a41c 100644
--- a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/RelyingPartyProxySigningParametersResolverTest.java
+++ b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/RelyingPartyProxySigningParametersResolverTest.java
@@ -66,6 +66,9 @@ import net.shibboleth.utilities.java.support.resolver.ResolverException;
 /** Tests for RelyingPartyProxySigningParametersResolver.*/
 public class RelyingPartyProxySigningParametersResolverTest extends AbstractOIDCTest {
     
+    /** A 256 bit client_secret.*/
+    private static final String TWO_FIVE_SIX_BIT_CLIENT_SECRET = "!A%D*G-KaPdSgVkYp3s6v8y/B?E(H+Mb";
+    
     private RelyingPartyProxySigningParametersResolver resolver;
     
     private RelyingPartyContext rpc;
@@ -102,7 +105,7 @@ public class RelyingPartyProxySigningParametersResolverTest extends AbstractOIDC
     public void testResolveSuccess_StaticCredentials() throws ResolverException {
         final CriteriaSet criteria = buildCriteria(List.of(SignatureConstants.ALGO_ID_SIGNATURE_HS_256));
         criteria.add(new ClientSecretCredentialCriterion(
-                new DefaultClientSecretCredential("atestsecret")));
+                new DefaultClientSecretCredential(TWO_FIVE_SIX_BIT_CLIENT_SECRET)));
         final Iterable<SignatureSigningParameters> params = resolver.resolve(criteria);
         assertNotNull(params);
         assertTrue(params.iterator().hasNext());
@@ -114,7 +117,7 @@ public class RelyingPartyProxySigningParametersResolverTest extends AbstractOIDC
     public void testResolveFail_StaticCredentials_UnsupportedMethod() throws ResolverException {
         final CriteriaSet criteria = buildCriteria(List.of(SignatureConstants.ALGO_ID_SIGNATURE_RS_256));
         criteria.add(new ClientSecretCredentialCriterion(
-                new DefaultClientSecretCredential("atestsecret")));
+                new DefaultClientSecretCredential(TWO_FIVE_SIX_BIT_CLIENT_SECRET)));
         final Iterable<SignatureSigningParameters> params = resolver.resolve(criteria);
         assertNotNull(params);
         assertFalse(params.iterator().hasNext());
@@ -125,7 +128,7 @@ public class RelyingPartyProxySigningParametersResolverTest extends AbstractOIDC
         final CriteriaSet criteria = buildCriteria(List.of(SignatureConstants.ALGO_ID_SIGNATURE_RS_256, 
                 SignatureConstants.ALGO_ID_SIGNATURE_HS_256));
         criteria.add(new ClientSecretCredentialCriterion(
-                new DefaultClientSecretCredential("atestsecret")));;
+                new DefaultClientSecretCredential(TWO_FIVE_SIX_BIT_CLIENT_SECRET)));;
         final Iterable<SignatureSigningParameters> params = resolver.resolve(criteria);
         assertNotNull(params);
         assertTrue(params.iterator().hasNext());
@@ -138,7 +141,7 @@ public class RelyingPartyProxySigningParametersResolverTest extends AbstractOIDC
         final CriteriaSet criteria = buildCriteria(List.of(SignatureConstants.ALGO_ID_SIGNATURE_RS_256, 
                 SignatureConstants.ALGO_ID_SIGNATURE_HS_256));
         criteria.add(new ClientSecretCredentialCriterion(
-                new DefaultClientSecretCredential("atestsecret")));
+                new DefaultClientSecretCredential(TWO_FIVE_SIX_BIT_CLIENT_SECRET)));
         
         // Now let the OP support one of those which matches the credential
         final OIDCProviderMetadata metadata = 
@@ -158,7 +161,7 @@ public class RelyingPartyProxySigningParametersResolverTest extends AbstractOIDC
         final CriteriaSet criteria = buildCriteria(List.of(SignatureConstants.ALGO_ID_SIGNATURE_RS_256, 
                 SignatureConstants.ALGO_ID_SIGNATURE_HS_256));
         criteria.add(new ClientSecretCredentialCriterion(
-                new DefaultClientSecretCredential("atestsecret")));
+                new DefaultClientSecretCredential(TWO_FIVE_SIX_BIT_CLIENT_SECRET)));
         
         // Now let the OP support none of those supported by the config
         final OIDCProviderMetadata metadata = 
@@ -178,7 +181,7 @@ public class RelyingPartyProxySigningParametersResolverTest extends AbstractOIDC
         
         // Create the normal client_secret
         criteria.add(new ClientSecretCredentialCriterion(
-                new DefaultClientSecretCredential("atestsecret")));
+                new DefaultClientSecretCredential(TWO_FIVE_SIX_BIT_CLIENT_SECRET)));
         
         // Add an RSA type to the security config
         final BasicSignatureSigningConfiguration config = 
@@ -212,7 +215,7 @@ public class RelyingPartyProxySigningParametersResolverTest extends AbstractOIDC
         
         // Create the normal client_secret
         criteria.add(new ClientSecretCredentialCriterion(
-                new DefaultClientSecretCredential("atestsecret")));
+                new DefaultClientSecretCredential(TWO_FIVE_SIX_BIT_CLIENT_SECRET)));
         
         // Add an RSA type to the security config
         final BasicSignatureSigningConfiguration config = 
@@ -243,7 +246,7 @@ public class RelyingPartyProxySigningParametersResolverTest extends AbstractOIDC
         
         // Create the normal client_secret
         criteria.add(new ClientSecretCredentialCriterion(
-                new DefaultClientSecretCredential("atestsecret")));
+                new DefaultClientSecretCredential(TWO_FIVE_SIX_BIT_CLIENT_SECRET)));
         
         final BasicSignatureSigningConfiguration config = 
                 (BasicSignatureSigningConfiguration) 
@@ -269,7 +272,7 @@ public class RelyingPartyProxySigningParametersResolverTest extends AbstractOIDC
         
         // Create the normal client_secret
         criteria.add(new ClientSecretCredentialCriterion(
-                new DefaultClientSecretCredential("atestsecret")));
+                new DefaultClientSecretCredential(TWO_FIVE_SIX_BIT_CLIENT_SECRET)));
         
         final BasicSignatureSigningConfiguration config = 
                 (BasicSignatureSigningConfiguration) 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.