[java-idp-plugin-oidc-rp] branch main updated: Improve XML in-line comments

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=834cdc33eee39ae7ae23e682edcacb3ccb097436

The following commit(s) were added to refs/heads/main by this push:
     new 834cdc3  Improve XML in-line comments
834cdc3 is described below

commit 834cdc33eee39ae7ae23e682edcacb3ccb097436
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Feb 17 09:38:37 2023 +0000

    Improve XML in-line comments
---
 .../plugin/authn/oidc/rp/conf/authn/client-secret-credential.xml  | 4 ++--
 .../authn/oidc/rp/conf/authn/oidc-providermetadata-resolvers.xml  | 8 ++++++--
 .../authn/oidc/rp/conf/authn/providermetadata-resolver-system.xml | 2 +-
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/conf/authn/client-secret-credential.xml b/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/conf/authn/client-secret-credential.xml
index b056ff9..51558fd 100644
--- a/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/conf/authn/client-secret-credential.xml
+++ b/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/conf/authn/client-secret-credential.xml
@@ -10,8 +10,8 @@
     default-init-method="initialize" default-destroy-method="destroy">
 
     <!--
-    This file contains the default credential is based on the client_secret, and will be the only used credential in 
-    most cases for the RP-Proxy. This file should be imported into credentials.xml.
+        This file contains the default credential based on the client_secret, which will be the only used credential in 
+        most cases for the RP-Proxy. This file should be imported into credentials.xml.
     -->
 
     <bean id="shibboleth.authn.oidc.rp.DefaultCredential" parent="shibboleth.oidc.ClientSecretCredential"
diff --git a/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/conf/authn/oidc-providermetadata-resolvers.xml b/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/conf/authn/oidc-providermetadata-resolvers.xml
index 51398a2..70ede00 100644
--- a/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/conf/authn/oidc-providermetadata-resolvers.xml
+++ b/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/conf/authn/oidc-providermetadata-resolvers.xml
@@ -8,8 +8,11 @@
                            http://www.springframework.org/schema/util http://www.springframework.org/schema/util/spring-util.xsd"
 
     default-init-method="initialize" default-destroy-method="destroy">
-    <!-- User space config -->
     
+    <!-- 
+        The default metadata provider fetches OpenID Provider configuration metadata from the issuers well-known 
+        location. 
+    -->
     <util:list id="shibboleth.authn.oidc.rp.ProviderMetadataResolvers">
         <ref bean="ProviderHTTPResolver" />
     </util:list>
@@ -18,7 +21,8 @@
         <constructor-arg>
             <bean parent="shibboleth.authn.oidc.rp.CacheBuilder">
                 <constructor-arg>
-                    <bean p:cacheId="ProviderHTTPDynamicResolver" parent="shibboleth.authn.oidc.rp.BaseProviderDynamicCacheBuilderSpec" 
+                    <bean p:cacheId="ProviderHTTPDynamicResolver" 
+                    parent="shibboleth.authn.oidc.rp.BaseProviderDynamicCacheBuilderSpec" 
                     p:minCacheDuration="PT1M"
                     p:maxCacheDuration="PT2M"
                     p:cleanupTaskInterval="PT30S"/>
diff --git a/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/conf/authn/providermetadata-resolver-system.xml b/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/conf/authn/providermetadata-resolver-system.xml
index a811dff..96e7c81 100644
--- a/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/conf/authn/providermetadata-resolver-system.xml
+++ b/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/conf/authn/providermetadata-resolver-system.xml
@@ -40,7 +40,7 @@
     <bean id="shibboleth.authn.oidc.rp.CacheBuilder" factory-bean="cacheFactory" factory-method="build"
         abstract="true"/>
     
-    <!-- TODO Should we even provide the batch one? -->
+    
     <bean class="net.shibboleth.oidc.metadata.cache.impl.BatchMetadataCacheBuilderSpec" 
         id="shibboleth.authn.oidc.rp.BaseProviderBatchCacheBuilderSpec" abstract="true" 
         p:parsingStrategy-ref="shibboleth.authn.oidc.rp.DefaultOIDCProviderMetadataParsingStrategy"

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.