[java-identity-provider] branch main updated: Fix warnings.

Scott Cantor cantor.2 at osu.edu
Wed Feb 15 16:39:13 UTC 2023


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=11f03c2ec2d84f588359c9f9776f26eb05278fd2

The following commit(s) were added to refs/heads/main by this push:
     new 11f03c2ec Fix warnings.
11f03c2ec is described below

commit 11f03c2ec2d84f588359c9f9776f26eb05278fd2
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Feb 15 11:39:10 2023 -0500

    Fix warnings.
---
 .../main/java/net/shibboleth/idp/profile/audit/impl/WriteAuditLog.java | 1 -
 .../shibboleth/idp/profile/impl/InitializeProfileRequestContext.java   | 1 -
 .../shibboleth/idp/profile/audit/impl/PopulateAuditContextTest.java    | 1 +
 .../java/net/shibboleth/idp/profile/audit/impl/WriteAuditLogTest.java  | 3 +--
 .../idp/profile/config/tests/AbstractProfileConfigurationTest.java     | 1 +
 .../net/shibboleth/idp/profile/impl/AbstractProfileActionTest.java     | 1 +
 .../idp/profile/impl/InitializeProfileRequestContextTest.java          | 1 +
 .../idp/profile/impl/ProfileActionBeanFactoryPostProcessorTest.java    | 1 +
 .../idp/profile/impl/ProfileActionBeanPostProcessorTest.java           | 1 +
 .../net/shibboleth/idp/profile/impl/RecordResponseCompleteTest.java    | 1 +
 .../test/java/net/shibboleth/idp/profile/impl/ScriptedActionTest.java  | 1 +
 .../idp/profile/support/PathInfoSupportingFlowUrlHandlerTest.java      | 1 +
 12 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/audit/impl/WriteAuditLog.java b/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/audit/impl/WriteAuditLog.java
index 20cd0b614..17d7f21ff 100644
--- a/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/audit/impl/WriteAuditLog.java
+++ b/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/audit/impl/WriteAuditLog.java
@@ -23,7 +23,6 @@ import java.time.ZoneOffset;
 import java.time.format.DateTimeFormatter;
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
diff --git a/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/InitializeProfileRequestContext.java b/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/InitializeProfileRequestContext.java
index 2df36d958..4d402895d 100644
--- a/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/InitializeProfileRequestContext.java
+++ b/idp-profile-impl/src/main/java/net/shibboleth/idp/profile/impl/InitializeProfileRequestContext.java
@@ -119,7 +119,6 @@ public final class InitializeProfileRequestContext extends AbstractProfileAction
     
     /** {@inheritDoc} */
     @Override
-    @SuppressWarnings("unchecked")
     @Nonnull public Event execute(@Nonnull final RequestContext springRequestContext) {
 
         // We have to override execute() because the profile request context doesn't exist yet.
diff --git a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/audit/impl/PopulateAuditContextTest.java b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/audit/impl/PopulateAuditContextTest.java
index c96dc26f6..b2185cc4b 100644
--- a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/audit/impl/PopulateAuditContextTest.java
+++ b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/audit/impl/PopulateAuditContextTest.java
@@ -40,6 +40,7 @@ import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
 
 /** {@link PopulateAuditContext} unit test. */
+ at SuppressWarnings("javadoc")
 public class PopulateAuditContextTest {
 
     private RequestContext src;
diff --git a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/audit/impl/WriteAuditLogTest.java b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/audit/impl/WriteAuditLogTest.java
index 70ee5a319..63252183b 100644
--- a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/audit/impl/WriteAuditLogTest.java
+++ b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/audit/impl/WriteAuditLogTest.java
@@ -30,16 +30,15 @@ import org.testng.Assert;
 import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
 
-import jakarta.servlet.http.HttpServletRequest;
 import net.shibboleth.idp.profile.context.navigate.WebflowRequestContextProfileRequestContextLookup;
 import net.shibboleth.idp.profile.testing.ActionTestingSupport;
 import net.shibboleth.idp.profile.testing.RequestContextBuilder;
 import net.shibboleth.profile.context.AuditContext;
 import net.shibboleth.shared.component.ComponentInitializationException;
-import net.shibboleth.shared.primitive.NonnullSupplier;
 import net.shibboleth.shared.testing.ConstantSupplier;
 
 /** {@link WriteAuditLog} unit test. */
+ at SuppressWarnings("javadoc")
 public class WriteAuditLogTest {
 
     private RequestContext src;
diff --git a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/config/tests/AbstractProfileConfigurationTest.java b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/config/tests/AbstractProfileConfigurationTest.java
index 93a91af79..024ef1acb 100644
--- a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/config/tests/AbstractProfileConfigurationTest.java
+++ b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/config/tests/AbstractProfileConfigurationTest.java
@@ -31,6 +31,7 @@ import java.util.Arrays;
 import java.util.List;
 
 /** Unit test for {@link AbstractProfileConfiguration}. */
+ at SuppressWarnings("javadoc")
 public class AbstractProfileConfigurationTest {
 
     @Test
diff --git a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/AbstractProfileActionTest.java b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/AbstractProfileActionTest.java
index d125317af..c04698439 100644
--- a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/AbstractProfileActionTest.java
+++ b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/AbstractProfileActionTest.java
@@ -30,6 +30,7 @@ import org.testng.Assert;
 import org.testng.annotations.Test;
 
 /** Unit test for {@link AbstractProfileAction}. */
+ at SuppressWarnings("javadoc")
 public class AbstractProfileActionTest {
 
     @Test public void testActionExecution() throws Exception {
diff --git a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/InitializeProfileRequestContextTest.java b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/InitializeProfileRequestContextTest.java
index 571b726c0..50a9d3753 100644
--- a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/InitializeProfileRequestContextTest.java
+++ b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/InitializeProfileRequestContextTest.java
@@ -25,6 +25,7 @@ import org.testng.annotations.Test;
 import net.shibboleth.idp.profile.testing.RequestContextBuilder;
 
 /** Unit test for {@link InitializeProfileRequestContext}. */
+ at SuppressWarnings("javadoc")
 public class InitializeProfileRequestContextTest {
 
     @Test public void testExecute() throws Exception {
diff --git a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/ProfileActionBeanFactoryPostProcessorTest.java b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/ProfileActionBeanFactoryPostProcessorTest.java
index 7e2acfbfa..52506e80a 100644
--- a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/ProfileActionBeanFactoryPostProcessorTest.java
+++ b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/ProfileActionBeanFactoryPostProcessorTest.java
@@ -25,6 +25,7 @@ import org.testng.annotations.Test;
 import net.shibboleth.shared.annotation.Prototype;
 
 /** {@link ProfileActionBeanFactoryPostProcessor} unit test. */
+ at SuppressWarnings("javadoc")
 @ContextConfiguration({"ProfileActionBeanFactoryPostProcessorTest.xml"})
 public class ProfileActionBeanFactoryPostProcessorTest extends AbstractTestNGSpringContextTests {
 
diff --git a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/ProfileActionBeanPostProcessorTest.java b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/ProfileActionBeanPostProcessorTest.java
index 1e487264a..b1bd0a69d 100644
--- a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/ProfileActionBeanPostProcessorTest.java
+++ b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/ProfileActionBeanPostProcessorTest.java
@@ -27,6 +27,7 @@ import net.shibboleth.shared.component.ComponentInitializationException;
 
 /** {@link ProfileActionBeanPostProcessor} unit test. */
 @ContextConfiguration({"ProfileActionBeanPostProcessorTest.xml"})
+ at SuppressWarnings("javadoc")
 public class ProfileActionBeanPostProcessorTest extends AbstractTestNGSpringContextTests {
 
     @Test public void testPostProcessAfterInitialization() {
diff --git a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/RecordResponseCompleteTest.java b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/RecordResponseCompleteTest.java
index fba2186a6..6f72c7737 100644
--- a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/RecordResponseCompleteTest.java
+++ b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/RecordResponseCompleteTest.java
@@ -28,6 +28,7 @@ import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
 
 /** Unit test for {@link RecordResponseComplete}. */
+ at SuppressWarnings("javadoc")
 public class RecordResponseCompleteTest {
 
     RecordResponseComplete action;
diff --git a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/ScriptedActionTest.java b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/ScriptedActionTest.java
index 6777ca67a..8f890e1d1 100644
--- a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/ScriptedActionTest.java
+++ b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/impl/ScriptedActionTest.java
@@ -32,6 +32,7 @@ import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
 
 /** Unit test for {@link ScriptedAction}. */
+ at SuppressWarnings("javadoc")
 public class ScriptedActionTest {
 
     private RequestContext rc;
diff --git a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/support/PathInfoSupportingFlowUrlHandlerTest.java b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/support/PathInfoSupportingFlowUrlHandlerTest.java
index f9d00f55d..381f4960a 100644
--- a/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/support/PathInfoSupportingFlowUrlHandlerTest.java
+++ b/idp-profile-impl/src/test/java/net/shibboleth/idp/profile/support/PathInfoSupportingFlowUrlHandlerTest.java
@@ -26,6 +26,7 @@ import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
 
 /** {@link PathInfoSupportingFlowUrlHandler} unit test. */
+ at SuppressWarnings("javadoc")
 public class PathInfoSupportingFlowUrlHandlerTest {
 
     MockHttpServletRequest request;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list