[JIRA] (IDP-2071) Move RelyingParty "layer" into java-shib-profile

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-2071 ( https://shibboleth.atlassian.net/browse/IDP-2071?atlOrigin=eyJpIjoiZjMyYTZhMzgzNWJlNDI5MmFmNDkwNzZlN2FjYjEyZTEiLCJwIjoiaiJ9 )

Re: Move RelyingParty "layer" into java-shib-profile ( https://shibboleth.atlassian.net/browse/IDP-2071?atlOrigin=eyJpIjoiZjMyYTZhMzgzNWJlNDI5MmFmNDkwNzZlN2FjYjEyZTEiLCJwIjoiaiJ9 )

There are two big issues with this, one functional and one deployer-centric.

The functional change is the move to an explicit VerifiedProfileCriterion to signal whether the unverified RP config should be returned. I don’t love this, but it’s somewhat more generic and pluggable for callers I guess. As near as I can tell, the delegating version used by the SOAP client seems to have implicitly assumed verified behavior. Separately, it doesn’t seem as though the SOAP client usage populates metadata, which would greatly limit RP override evaluation, will open a separate bug for that to review. That’s not a new issue.

The deployer change is relocating the package for RelyingPartyContext to drop “idp” out, which I wouldn’t do except that there are definitely IdP-only classes that would need to stay in that package, so either we rename all those so we can keep the package name of something outside the IdP including “idp”, or we bite the bullet and rename that qualified class name. That matters because it’s very common in scripts to access the RelyingPartyContext via string class name, so this breaks scripts.

I looked at various workarounds and I’m not really seeing anything great so far. It’s quite a trivial/mechanical change of course.

( https://shibboleth.atlassian.net/browse/IDP-2071#add-comment?atlOrigin=eyJpIjoiZjMyYTZhMzgzNWJlNDI5MmFmNDkwNzZlN2FjYjEyZTEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2071#add-comment?atlOrigin=eyJpIjoiZjMyYTZhMzgzNWJlNDI5MmFmNDkwNzZlN2FjYjEyZTEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100216- sha1:7a51a57 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230214/f3ad5478/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-187ed9a3-2c27-47d2-857b-e0a2ad34af2f
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230214/f3ad5478/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-e18675ab-61f0-4108-b8c6-453f9d8ab363
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230214/f3ad5478/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-7fc1b406-7341-43f4-a2ae-aa74f264e6bd
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230214/f3ad5478/attachment-0005.png>