[java-idp-plugin-oidc-rp] branch main updated: Remove unused lookup function

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=06f0818bf77abbcfb78ab85694fca688903fced8

The following commit(s) were added to refs/heads/main by this push:
     new 06f0818  Remove unused lookup function
06f0818 is described below

commit 06f0818bf77abbcfb78ab85694fca688903fced8
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Mon Feb 13 10:13:12 2023 +0000

    Remove unused lookup function
---
 .../DefaultClientIDForIssuerLookupFunction.java    | 78 ----------------------
 .../impl/NonceValidationActivationCondition.java   |  2 +-
 2 files changed, 1 insertion(+), 79 deletions(-)

diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/metadata/impl/DefaultClientIDForIssuerLookupFunction.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/metadata/impl/DefaultClientIDForIssuerLookupFunction.java
deleted file mode 100644
index 2b852c1..0000000
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/metadata/impl/DefaultClientIDForIssuerLookupFunction.java
+++ /dev/null
@@ -1,78 +0,0 @@
-/*
- * Licensed to the University Corporation for Advanced Internet Development,
- * Inc. (UCAID) under one or more contributor license agreements.  See the
- * NOTICE file distributed with this work for additional information regarding
- * copyright ownership. The UCAID licenses this file to You under the Apache
- * License, Version 2.0 (the "License"); you may not use this file except in
- * compliance with the License.  You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package net.shibboleth.idp.plugin.authn.oidc.rp.metadata.impl;
-
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.Map;
-
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
-
-import org.opensaml.messaging.context.MessageContext;
-import org.opensaml.messaging.context.navigate.ContextDataLookupFunction;
-
-import com.nimbusds.oauth2.sdk.id.ClientID;
-import com.nimbusds.oauth2.sdk.id.Issuer;
-
-import net.shibboleth.oidc.metadata.context.OIDCProviderMetadataContext;
-import net.shibboleth.utilities.java.support.annotation.ParameterName;
-import net.shibboleth.utilities.java.support.annotation.constraint.NonnullElements;
-
-
-/**
- * Strategy to pull out the ID of the OIDC Client registered to talk to the discovered/configured OP.
- */
-//TODO is this used?
-public class DefaultClientIDForIssuerLookupFunction implements ContextDataLookupFunction<MessageContext, ClientID> {
-    
-    /** A mapping between an OP Issuer and an RP Client.*/
-    @Nonnull @NonnullElements private final Map<Issuer, ClientID> issuerToClientMap;
-    
-    /**
-     * 
-     * Constructor.
-     *
-     * @param map the issuer to client lookup map.
-     */
-    public DefaultClientIDForIssuerLookupFunction(
-            @Nullable @ParameterName(name = "issuerToClientMap") final Map<String, String> map) {
-        if (map == null) {
-            issuerToClientMap = Collections.emptyMap();
-        } else {
-            issuerToClientMap = new HashMap<>(map.size());
-            for (final Map.Entry<String, String> entry : map.entrySet()) {
-                issuerToClientMap.put(new Issuer(entry.getKey()), new ClientID(entry.getValue()));
-            }            
-        }
-    }
-
-    /** {@inheritDoc} */
-    @Override
-    @Nullable public ClientID apply(@Nullable final MessageContext input) {
-        if (input == null) {
-            return null;
-        }
-        final OIDCProviderMetadataContext provider = input.getSubcontext(OIDCProviderMetadataContext.class);
-        if (provider == null || provider.getProviderInformation() == null) {
-            return null;
-        }
-        return issuerToClientMap.get(provider.getProviderInformation().getIssuer());
-    }
-
-}
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/NonceValidationActivationCondition.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/NonceValidationActivationCondition.java
index 7b361db..6ca196b 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/NonceValidationActivationCondition.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/NonceValidationActivationCondition.java
@@ -33,7 +33,7 @@ import net.shibboleth.utilities.java.support.logic.Constraint;
 
 /**
  * Determines if nonce validation should occur. True iff a nonce is present in the authentication request, 
- * false otherwise see section 3.1.3.7 of the OpenID Connect core 1.0 specification.
+ * false otherwise.
  */
 @ThreadSafe
 public class NonceValidationActivationCondition implements BiPredicate<ProfileRequestContext, JWTClaimsSet>{

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.