[JIRA] (MDA-278) Investigate performance of EmptyContainerStrippingStage

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *created* an issue

Metadata Aggregator ( https://shibboleth.atlassian.net/browse/MDA?atlOrigin=eyJpIjoiYjFlZjk4NWNmNzEyNGI3ODhiYWNhOGMzNmJmYzM3M2MiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/MDA-278?atlOrigin=eyJpIjoiYjFlZjk4NWNmNzEyNGI3ODhiYWNhOGMzNmJmYzM3M2MiLCJwIjoiaiJ9 ) MDA-278 ( https://shibboleth.atlassian.net/browse/MDA-278?atlOrigin=eyJpIjoiYjFlZjk4NWNmNzEyNGI3ODhiYWNhOGMzNmJmYzM3M2MiLCJwIjoiaiJ9 ) Investigate performance of EmptyContainerStrippingStage ( https://shibboleth.atlassian.net/browse/MDA-278?atlOrigin=eyJpIjoiYjFlZjk4NWNmNzEyNGI3ODhiYWNhOGMzNmJmYzM3M2MiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 0.9.2 Assignee: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) Components: DOM Metadata Created: 10/Feb/23 4:06 AM Fix Versions: 0.10.0 Priority: Trivial Reporter: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 )

In the UK federation tooling, we have one situation in which an instance of EmptyContainerStrippingStage is taking a surprisingly large amount of time: something like 90s to trim (probably a large number of) empty <Extensions> elements from a modified aggregate.

I don’t see why this should be the case, as the stage just operates by:

* Getting a list of <Extensions> elements,
* Iterating through it (backwards, to handle nested cases),
* Checking each to see if it has element children,
* Removing those that are empty.

These should all be fairly quick DOM operations.

( https://shibboleth.atlassian.net/browse/MDA-278#add-comment?atlOrigin=eyJpIjoiYjFlZjk4NWNmNzEyNGI3ODhiYWNhOGMzNmJmYzM3M2MiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-278#add-comment?atlOrigin=eyJpIjoiYjFlZjk4NWNmNzEyNGI3ODhiYWNhOGMzNmJmYzM3M2MiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100215- sha1:1034aa4 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230210/bfd8a78f/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-883c0a10-cb6f-4008-bfe1-c1943a2e0e6e
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230210/bfd8a78f/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-8f5b3241-7d1b-4269-9424-96c116736c83
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230210/bfd8a78f/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c8bd9810-aecc-4c1b-8216-7637c55b20e0
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230210/bfd8a78f/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a53c3e06-fdc8-4ef8-bf1e-83d238cc38f4
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230210/bfd8a78f/attachment-0007.png>