[java-identity-provider] 02/02: IDP-2069 Null handling

Rod Widdowson rdw at steadingsoftware.com
Thu Feb 9 10:40:51 UTC 2023


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=cd91d388d26f49658637978b76b00830c19e96d0

commit cd91d388d26f49658637978b76b00830c19e96d0
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Thu Feb 9 10:32:29 2023 +0000

    IDP-2069 Null handling
    
    https://shibboleth.atlassian.net/browse/IDP-2069
    
    Fix broken annotation on net.shibboleth.idp.cas.protocol.TicketValidationRequest
    
    The pgtUrl can be null.
---
 .../net/shibboleth/idp/cas/protocol/TicketValidationRequest.java | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/idp-cas-api/src/main/java/net/shibboleth/idp/cas/protocol/TicketValidationRequest.java b/idp-cas-api/src/main/java/net/shibboleth/idp/cas/protocol/TicketValidationRequest.java
index afff896c7..eb7157631 100644
--- a/idp-cas-api/src/main/java/net/shibboleth/idp/cas/protocol/TicketValidationRequest.java
+++ b/idp-cas-api/src/main/java/net/shibboleth/idp/cas/protocol/TicketValidationRequest.java
@@ -18,6 +18,7 @@
 package net.shibboleth.idp.cas.protocol;
 
 import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
 
 import net.shibboleth.shared.primitive.StringSupport;
 
@@ -32,7 +33,7 @@ public class TicketValidationRequest extends ServiceTicketResponse {
     private boolean renew;
 
     /** Proxy-granting ticket validation URL. */
-    @Nonnull private String pgtUrl;
+    @Nullable private String pgtUrl;
 
     /**
      * Creates a CAS ticket validation request message.
@@ -67,7 +68,7 @@ public class TicketValidationRequest extends ServiceTicketResponse {
      * 
      * @return proxy-granting ticket validation URL
      */
-    @Nonnull public String getPgtUrl() {
+    @Nullable public String getPgtUrl() {
         return pgtUrl;
     }
 
@@ -76,7 +77,7 @@ public class TicketValidationRequest extends ServiceTicketResponse {
      * 
      * @param url proxy-granting ticket validation URL
      */
-    public void setPgtUrl(@Nonnull final String url) {
-        this.pgtUrl = StringSupport.trimOrNull(url);
+    public void setPgtUrl(@Nullable final String url) {
+        pgtUrl = StringSupport.trimOrNull(url);
     }
 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list