[JIRA] (JPAR-218) Compile everything with the javac -parameters option

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on JPAR-218 ( https://shibboleth.atlassian.net/browse/JPAR-218?atlOrigin=eyJpIjoiNTY1NWQ0MGNkY2Y5NDJkZWE4ZTBlZDAyYTE4NGFhMzkiLCJwIjoiaiJ9 )

Re: Compile everything with the javac -parameters option ( https://shibboleth.atlassian.net/browse/JPAR-218?atlOrigin=eyJpIjoiNTY1NWQ0MGNkY2Y5NDJkZWE4ZTBlZDAyYTE4NGFhMzkiLCJwIjoiaiJ9 )

It’s interesting that you should mention that, because yes and no. The debug flag is only explicitly set in the “release” profile, but my research in https://shibboleth.atlassian.net/browse/JPAR-195 ( https://shibboleth.atlassian.net/browse/JPAR-195 ) claims that it’s on by default.

For the experiment, I added “parameters” to the default configuration as well as to the “release” profile, on the basis that this is a functional change and it shouldn’t be enabled only in a release build. The one I tested didn’t use the release profile and things still worked for me in terms of Spring being able to introspect the constructor name on that particular bean. But as I say I think that’s probably implicitly using “debug” as well.

You’re probably right that “debug” isn’t required for introspection any more; I guess I’m nevertheless reluctant to explicitly disable something that’s on by default on the basis that it might have other implications.

I do think that we should try and push https://shibboleth.atlassian.net/browse/JPAR-195 ( https://shibboleth.atlassian.net/browse/JPAR-195 ) to completion for v5, though, so that we’re not having this discussion again next time round. I’ll add a note there to indicate that we should reconsider whether we should disable “debug” there.

( https://shibboleth.atlassian.net/browse/JPAR-218#add-comment?atlOrigin=eyJpIjoiNTY1NWQ0MGNkY2Y5NDJkZWE4ZTBlZDAyYTE4NGFhMzkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JPAR-218#add-comment?atlOrigin=eyJpIjoiNTY1NWQ0MGNkY2Y5NDJkZWE4ZTBlZDAyYTE4NGFhMzkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:c33f0bb )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230207/41c2613f/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-827ca443-3b55-4e34-b305-79a2c9f70ec6
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230207/41c2613f/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c4bcf45f-89b3-4c7c-8449-c7e819561810
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230207/41c2613f/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-2d71b426-25d8-4374-a8ee-5e4cc1b94595
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230207/41c2613f/attachment-0005.png>