[JIRA] (OSJ-374) AlgorithmRegistry indexes signing algorithms only by key type + digest

[Brent Putman (Jira)]

Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) *created* an issue

OpenSAML - Java ( https://shibboleth.atlassian.net/browse/OSJ?atlOrigin=eyJpIjoiNjlhOGNkYWIwY2FmNDU2Mjk2OTdlZjI0YjBiYmRiOWQiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/OSJ-374?atlOrigin=eyJpIjoiNjlhOGNkYWIwY2FmNDU2Mjk2OTdlZjI0YjBiYmRiOWQiLCJwIjoiaiJ9 ) OSJ-374 ( https://shibboleth.atlassian.net/browse/OSJ-374?atlOrigin=eyJpIjoiNjlhOGNkYWIwY2FmNDU2Mjk2OTdlZjI0YjBiYmRiOWQiLCJwIjoiaiJ9 ) AlgorithmRegistry indexes signing algorithms only by key type + digest ( https://shibboleth.atlassian.net/browse/OSJ-374?atlOrigin=eyJpIjoiNjlhOGNkYWIwY2FmNDU2Mjk2OTdlZjI0YjBiYmRiOWQiLCJwIjoiaiJ9 )

Issue Type: Bug Assignee: Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) Components: Security Created: 01/Feb/23 9:32 PM Fix Versions: 5.0.0 Priority: Trivial Reporter: Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e )

AlgorithmRegistry indexes signing algorithms by key type + digest only. With the appearance of more modern algorithms, this does not result in a unique index. For example see:

http://www.w3.org/2007/05/xmldsig-more#sha256-rsa-MGF1 ( http://www.w3.org/2007/05/xmldsig-more#sha256-rsa-MGF1 )

vs.

http://www.w3.org/2001/04/xmldsig-more#rsa-sha256 ( http://www.w3.org/2001/04/xmldsig-more#rsa-sha256 )

Possibly can fix by adding in more info to the indexing key class + an overloaded lookup method that takes an optional params arg.

But also consider whether we still need/want this indexing. We aren’t currently using. Consider adding support for this indexing in metadata-based signing params resolution.

If we don’t wind up using the indexing, I suppose consider just deprecating and removing the indexing.

( https://shibboleth.atlassian.net/browse/OSJ-374#add-comment?atlOrigin=eyJpIjoiNjlhOGNkYWIwY2FmNDU2Mjk2OTdlZjI0YjBiYmRiOWQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/OSJ-374#add-comment?atlOrigin=eyJpIjoiNjlhOGNkYWIwY2FmNDU2Mjk2OTdlZjI0YjBiYmRiOWQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230202/14eafc6c/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-4fa2a891-881f-475f-b6a4-977eb664a2ea
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230202/14eafc6c/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-b245c2a6-8024-4c61-96a8-78ecc6e4b98d
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230202/14eafc6c/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-b34583b9-99bf-4508-a2f9-e23b785270eb
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230202/14eafc6c/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-c93ce6b9-1f8a-4979-a886-c94e25e76e32
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230202/14eafc6c/attachment-0007.png>