[JIRA] (JPAR-218) Compile everything with the javac -parameters option

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JPAR-218 ( https://shibboleth.atlassian.net/browse/JPAR-218?atlOrigin=eyJpIjoiNjc5ZjI2MTA5ZWM4NDNjNGFiYTNjNDQxMGQ2NTBiMWMiLCJwIjoiaiJ9 )

Re: Compile everything with the javac -parameters option ( https://shibboleth.atlassian.net/browse/JPAR-218?atlOrigin=eyJpIjoiNjc5ZjI2MTA5ZWM4NDNjNGFiYTNjNDQxMGQ2NTBiMWMiLCJwIjoiaiJ9 )

I didn’t realize the difference between the approaches, I can certainly see why that’s got to go. I would presume that the discoverer is not essential if we compile this way, but it’s original idea (as Rod noted for V4) was that we’d use it only in cases where we wished to change the argument name for some reason (like a spelling mistake).

I realize why setters cause issues, and it’s an odd thing to say given our null fix march, but to me, arguments by name is far worse than the issues around immutability, especially since we’re not going to suddenly move to c’tors and factory methods everywhere else anyway. Of the two, I do strongly believe named arguments are the greater evil, and positional arguments are far more evil than either.

( https://shibboleth.atlassian.net/browse/JPAR-218#add-comment?atlOrigin=eyJpIjoiNjc5ZjI2MTA5ZWM4NDNjNGFiYTNjNDQxMGQ2NTBiMWMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JPAR-218#add-comment?atlOrigin=eyJpIjoiNjc5ZjI2MTA5ZWM4NDNjNGFiYTNjNDQxMGQ2NTBiMWMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/f5479575/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-58cf0b84-69e1-40d2-a345-0530f1a8b292
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/f5479575/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-3a2b6c19-62c6-40f6-932b-0181582bbf9f
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/f5479575/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-17875ff8-c9d5-4374-bb07-9f87c0042c98
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/f5479575/attachment-0005.png>