[JIRA] (JPAR-218) Compile everything with the javac -parameters option
Ian Young (Jira)
jira at shibboleth.atlassian.net
Wed Feb 1 18:20:30 UTC 2023
Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on JPAR-218 ( https://shibboleth.atlassian.net/browse/JPAR-218?atlOrigin=eyJpIjoiZjVkOGNhMzA4Mzk1NDI1NzhmNDkxZjJmZTk3MzRiZTEiLCJwIjoiaiJ9 )
Re: Compile everything with the javac -parameters option ( https://shibboleth.atlassian.net/browse/JPAR-218?atlOrigin=eyJpIjoiZjVkOGNhMzA4Mzk1NDI1NzhmNDkxZjJmZTk3MzRiZTEiLCJwIjoiaiJ9 )
The current fallback (using the debug information) isn’t JDK-API-level introspection, it involves parsing the classfile. That's what they are talking about dropping, as I understand it.
I guess -parameters puts the information somewhere that there’s JDK API to access without grepping around in the classfiles.
Unfortunately I (almost certainly) won’t be around for the call, that’s the reason I raised a detailed ticket.
As to “move away from constructors”, I guess I understand why you’d say that but (a) it’s hard to do that 100% and (b) that direction means moving away from immutable objects (e.g., losing the ability to have a bean which is a record ) and makes it harder to do nullability checks. It may solve one problem, but it introduces its own.
( https://shibboleth.atlassian.net/browse/JPAR-218#add-comment?atlOrigin=eyJpIjoiZjVkOGNhMzA4Mzk1NDI1NzhmNDkxZjJmZTk3MzRiZTEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JPAR-218#add-comment?atlOrigin=eyJpIjoiZjVkOGNhMzA4Mzk1NDI1NzhmNDkxZjJmZTk3MzRiZTEiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/70077df0/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-7d30b7e9-adb2-46ec-9894-b783f5613a05
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/70077df0/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-eccb66df-e380-4752-b091-2382b4021827
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/70077df0/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-dfae785d-b6cd-4368-9de8-b2d4a15fa23c
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/70077df0/attachment-0005.png>
More information about the commits
mailing list