[JIRA] (MDA-271) Refactor SimpleCommandLine to avoid JVM exit, correctly handle context lifetime

Ian Young (Jira) jira at shibboleth.atlassian.net
Wed Feb 1 16:31:05 UTC 2023


Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on MDA-271 ( https://shibboleth.atlassian.net/browse/MDA-271?atlOrigin=eyJpIjoiZGYyMWE4MDFmNGJmNGEwY2IzNmY4MTI2MGQ4Y2YxODkiLCJwIjoiaiJ9 )

Re: Refactor SimpleCommandLine to avoid JVM exit, correctly handle context lifetime ( https://shibboleth.atlassian.net/browse/MDA-271?atlOrigin=eyJpIjoiZGYyMWE4MDFmNGJmNGEwY2IzNmY4MTI2MGQ4Y2YxODkiLCJwIjoiaiJ9 )

Reviewed this and raised https://shibboleth.atlassian.net/browse/MDA-275 ( https://shibboleth.atlassian.net/browse/MDA-275 ) to deal with the daemon thread issue. It’s better, I think, to fix that at the level of the individual stages than continuing with the old behaviour, which might in principle cause real non-daemon threads to be prematurely terminated. The change does need to be documented, though.

( https://shibboleth.atlassian.net/browse/MDA-271#add-comment?atlOrigin=eyJpIjoiZGYyMWE4MDFmNGJmNGEwY2IzNmY4MTI2MGQ4Y2YxODkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-271#add-comment?atlOrigin=eyJpIjoiZGYyMWE4MDFmNGJmNGEwY2IzNmY4MTI2MGQ4Y2YxODkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/a38160c0/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-195e65cf-1e20-4b89-a152-274566042c21
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/a38160c0/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-f3202440-74f1-4cb5-9ca5-ea0f8b0d6a6a
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/a38160c0/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-3081e933-6fe8-438d-8ea6-01ae942d91eb
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/a38160c0/attachment-0005.png>


More information about the commits mailing list