[JIRA] (JSSH-22) Consider returning null from Spring boolean converters
Scott Cantor (Jira)
jira at shibboleth.atlassian.net
Wed Feb 1 13:32:15 UTC 2023
Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JSSH-22 ( https://shibboleth.atlassian.net/browse/JSSH-22?atlOrigin=eyJpIjoiYTM5MTAyOTBkNWQ1NGVlMTg0Y2I2YzY5ZDIzMDU1MGUiLCJwIjoiaiJ9 )
Re: Consider returning null from Spring boolean converters ( https://shibboleth.atlassian.net/browse/JSSH-22?atlOrigin=eyJpIjoiYTM5MTAyOTBkNWQ1NGVlMTg0Y2I2YzY5ZDIzMDU1MGUiLCJwIjoiaiJ9 )
We’re gonna have to actually review the calling code, which I’ve never actually tracked down in full. Debugger should show us what it does to cycle through the converters. I can’t really understand why they define the interface to return null if that breaks the whole system but maybe I need to review the interface documentation.
( https://shibboleth.atlassian.net/browse/JSSH-22#add-comment?atlOrigin=eyJpIjoiYTM5MTAyOTBkNWQ1NGVlMTg0Y2I2YzY5ZDIzMDU1MGUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-22#add-comment?atlOrigin=eyJpIjoiYTM5MTAyOTBkNWQ1NGVlMTg0Y2I2YzY5ZDIzMDU1MGUiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:06410ea )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/7552f5d7/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-e043807b-175a-43b7-95a7-741187610c92
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/7552f5d7/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e859ab82-3d83-4afb-a805-a716a9449c32
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/7552f5d7/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-7d30dbaf-d64d-4897-9442-9c4d26e8c23c
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230201/7552f5d7/attachment-0005.png>
More information about the commits
mailing list