[java-idp-plugin-webauthn] branch main updated: Fix issue preventing usernameless authentication

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=de7bcef4922d72609335717275672528e8e8f6bf

The following commit(s) were added to refs/heads/main by this push:
     new de7bcef  Fix issue preventing usernameless authentication
de7bcef is described below

commit de7bcef4922d72609335717275672528e8e8f6bf
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Thu Dec 14 16:54:26 2023 +0000

    Fix issue preventing usernameless authentication
    
     - Still need to distingush the flows for usernameless, passwordless,
    and u2f.
---
 .../webauthn/context/WebAuthnAuthenticationContext.java    | 14 +-------------
 .../webauthn/admin/impl/StorePublicKeyCredential.java      |  1 -
 .../webauthn/impl/AbstractWebAuthnRegistrationAction.java  |  1 +
 3 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/context/WebAuthnAuthenticationContext.java b/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/context/WebAuthnAuthenticationContext.java
index 153a7d5..61c57f1 100644
--- a/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/context/WebAuthnAuthenticationContext.java
+++ b/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/context/WebAuthnAuthenticationContext.java
@@ -32,10 +32,7 @@ public final class WebAuthnAuthenticationContext extends BaseWebAuthnContext {
     // TODO maybe generate the JSON during the webflow action to populate the view
     /** The public key credential request options for authentication represented as a JSON string.*/ 
     @Nullable private String publicKeyCredentialRequestOptionsJSON;
-    
-    /** The userhandle supplied to the authenticator during registration. As generated by the IdP.*/
-    @Nullable private byte[] userHandle;
-  
+
     
     /**
      * Set the public key, as a byte array, in COSE_Key format.
@@ -109,15 +106,6 @@ public final class WebAuthnAuthenticationContext extends BaseWebAuthnContext {
         return authenticatorAssertionResponse;
     }
         
-    /**
-     * Get the userId used to map public key credentials to user accounts.
-     * 
-     * @return the userHandle.
-     */
-    @Override
-    public byte[] getUserHandle() {
-        return userHandle;
-    }
     
     /**
      * @return Returns the publicKeyCredentialRequestOptionsJSON.
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/impl/StorePublicKeyCredential.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/impl/StorePublicKeyCredential.java
index 2d788cb..8edd48e 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/impl/StorePublicKeyCredential.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/impl/StorePublicKeyCredential.java
@@ -133,7 +133,6 @@ public class StorePublicKeyCredential extends AbstractWebAuthnRegistrationAction
                     Optional.of(context.getCredentialNickname()), 
                     transports, Instant.now(), credential, Optional.empty());
             
-
             getCredentialRepository().addRegistrationByUsername(username, registration);
             log.debug("{} Added public key credential registration for user '{}' and key '{}' ", 
                     getLogPrefix(), username, registrationResult.getKeyId().getId().getBase64Url());
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AbstractWebAuthnRegistrationAction.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AbstractWebAuthnRegistrationAction.java
index 75a890c..d49ae51 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AbstractWebAuthnRegistrationAction.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AbstractWebAuthnRegistrationAction.java
@@ -128,6 +128,7 @@ public abstract class AbstractWebAuthnRegistrationAction extends AbstractProfile
      * 
      * @return the credential repository.
      */
+    //TODO should even storage operations go through the client. 
     public StorageServiceCredentialRepository getCredentialRepository() {
         return credentialRepository;
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.