[java-opensaml] branch main updated: Mark old HttpSOAPClient impl as deprecated.

Brent Putman putmanb at georgetown.edu
Thu Aug 31 23:39:16 UTC 2023


This is an automated email from the git hooks/post-receive script.

putmanb pushed a commit to branch main
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=3a483d13c072b21ae3e02452da93e6fe059b494d

The following commit(s) were added to refs/heads/main by this push:
     new 3a483d13c Mark old HttpSOAPClient impl as deprecated.
3a483d13c is described below

commit 3a483d13c072b21ae3e02452da93e6fe059b494d
Author: Brent Putman <putmanb at georgetown.edu>
AuthorDate: Thu Aug 31 19:39:11 2023 -0400

    Mark old HttpSOAPClient impl as deprecated.
    
    We only use in the testbed.
---
 .../main/java/org/opensaml/soap/client/http/HttpSOAPClient.java   | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/HttpSOAPClient.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/HttpSOAPClient.java
index 7a2758159..f5bfc9302 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/HttpSOAPClient.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/HttpSOAPClient.java
@@ -33,7 +33,6 @@ import org.apache.hc.core5.http.ContentType;
 import org.apache.hc.core5.http.HttpEntity;
 import org.apache.hc.core5.http.HttpStatus;
 import org.apache.hc.core5.http.io.entity.ByteArrayEntity;
-import org.apache.hc.core5.http.io.entity.EntityUtils;
 import org.opensaml.core.xml.XMLObject;
 import org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport;
 import org.opensaml.core.xml.io.Marshaller;
@@ -63,15 +62,21 @@ import net.shibboleth.shared.annotation.constraint.NotEmpty;
 import net.shibboleth.shared.component.AbstractInitializableComponent;
 import net.shibboleth.shared.component.ComponentInitializationException;
 import net.shibboleth.shared.logic.Constraint;
+import net.shibboleth.shared.primitive.DeprecationSupport;
 import net.shibboleth.shared.primitive.LoggerFactory;
+import net.shibboleth.shared.primitive.DeprecationSupport.ObjectType;
 import net.shibboleth.shared.xml.ParserPool;
 import net.shibboleth.shared.xml.SerializeSupport;
 import net.shibboleth.shared.xml.XMLParserException;
 
 /**
  * SOAP client that uses HTTP as the underlying transport and POST as the binding.
+ * 
+ * @deprecated use instead a concrete implementation of {@link AbstractPipelineHttpSOAPClient},
+ *             such as {@link PipelineFactoryHttpSOAPClient}
  */
 @ThreadSafe
+ at Deprecated
 public class HttpSOAPClient extends AbstractInitializableComponent implements SOAPClient {
 
     /** Class logger. */
@@ -97,6 +102,7 @@ public class HttpSOAPClient extends AbstractInitializableComponent implements SO
     
     /** Constructor. */
     public HttpSOAPClient() {
+        DeprecationSupport.warn(ObjectType.CLASS, "HttpSOAPClient", null, "Pipeline-based SOAP client");
         soapClientContextLookupStrategy = new ChildContextLookup<>(SOAPClientContext.class);
         soap11ContextLookupStrategy = new ChildContextLookup<>(SOAP11Context.class);
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list