[java-shib-shared] branch main updated: Plug a small hole that would allow a connectioon to leak.

Scott Cantor cantor.2 at osu.edu
Tue Aug 29 16:58:44 UTC 2023


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-shared.git;a=commit;h=7a2f5fca1467f5bbed9e04ed8734969364f1f44e

The following commit(s) were added to refs/heads/main by this push:
     new 7a2f5fca Plug a small hole that would allow a connectioon to leak.
7a2f5fca is described below

commit 7a2f5fca1467f5bbed9e04ed8734969364f1f44e
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Aug 29 12:58:40 2023 -0400

    Plug a small hole that would allow a connectioon to leak.
---
 .../shibboleth/shared/spring/httpclient/resource/HTTPResource.java | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/resource/HTTPResource.java b/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/resource/HTTPResource.java
index 35c19f12..7e487d85 100644
--- a/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/resource/HTTPResource.java
+++ b/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/httpclient/resource/HTTPResource.java
@@ -173,7 +173,12 @@ public class HTTPResource extends AbstractIdentifiedInitializableComponent imple
         
         if (contextHandler != null) {
             log.debug("Invoking HttpClientContextHandler after execution");
-            contextHandler.invokeAfter(context, httpGet);
+            try {
+                contextHandler.invokeAfter(context, httpGet);
+            } catch (final Throwable e) {
+                closeResponse(response);
+                throw e;
+            }
         }
         
         reportCachingStatus(context);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list