[java-idp-oidc] 01/02: JOIDC-167 - SetRequestObjectToResponseContext HTTP resource leak

[Henri Mikkonen]

This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=100f77974852b3c7db7abf21eaf0feefd6af449c

commit 100f77974852b3c7db7abf21eaf0feefd6af449c
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Tue Aug 29 15:04:26 2023 +0300

    JOIDC-167 - SetRequestObjectToResponseContext HTTP resource leak
    
    https://shibboleth.atlassian.net/browse/JOIDC-167
---
 .../oidc/op/oauth2/profile/impl/SetRequestObjectToResponseContext.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oauth2/profile/impl/SetRequestObjectToResponseContext.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oauth2/profile/impl/SetRequestObjectToResponseContext.java
index b2a6dc62..17a2a457 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oauth2/profile/impl/SetRequestObjectToResponseContext.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oauth2/profile/impl/SetRequestObjectToResponseContext.java
@@ -175,8 +175,7 @@ public class SetRequestObjectToResponseContext extends AbstractOAuthAuthorizatio
         
         final HttpGet httpRequest = new HttpGet(getAuthorizationRequest().getRequestURI());
         final HttpClientContext httpContext = buildHttpContext(httpRequest);
-        try {
-            final ClassicHttpResponse response = httpClient.executeOpen(null, httpRequest, httpContext);
+        try (final ClassicHttpResponse response = httpClient.executeOpen(null, httpRequest, httpContext)) {
             HttpClientSecuritySupport.checkTLSCredentialEvaluated(httpContext, httpRequest.getUri().getScheme());
             if (response.getCode() == HttpStatus.SC_OK) {
                 final String requestObject = EntityUtils.toString(response.getEntity());

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.