[java-shib-profile] branch main updated: IDP-2161 - Installation updates can trip over module '.save' files

Scott Cantor cantor.2 at osu.edu
Tue Aug 22 14:18:02 UTC 2023


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-profile.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-profile.git;a=commit;h=a8b6702684ed9ed97675152e28a4604fb80de8af

The following commit(s) were added to refs/heads/main by this push:
     new a8b6702  IDP-2161 - Installation updates can trip over module '.save' files
a8b6702 is described below

commit a8b6702684ed9ed97675152e28a4604fb80de8af
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Aug 22 10:17:56 2023 -0400

    IDP-2161 - Installation updates can trip over module '.save' files
    
    https://shibboleth.atlassian.net/browse/IDP-2161
    
    Change exception to warning.
---
 .../src/main/java/net/shibboleth/profile/module/AbstractModule.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/shib-profile-api/src/main/java/net/shibboleth/profile/module/AbstractModule.java b/shib-profile-api/src/main/java/net/shibboleth/profile/module/AbstractModule.java
index f1260ac..6984acb 100644
--- a/shib-profile-api/src/main/java/net/shibboleth/profile/module/AbstractModule.java
+++ b/shib-profile-api/src/main/java/net/shibboleth/profile/module/AbstractModule.java
@@ -505,7 +505,7 @@ public abstract class AbstractModule implements Module {
                         destPath = Path.of(moduleContext.getInstallLocation()).resolve(destination);
                         final Path savedPath = destPath.resolveSibling(destPath.getFileName() + getSaveExtension());
                         if (savedPath.toFile().exists()) {
-                            throw new IOException(savedPath + " exists, aborting");
+                            log.warn("Module {} overwriting older saved file: {}", getId(), savedPath);
                         }
                         Files.copy(destPath, savedPath, StandardCopyOption.REPLACE_EXISTING);
                         log.debug("Module {} preserved {}", getId(), destPath);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list