[java-opensaml] branch main updated: Remove some test scope usage of JAXB.

Brent Putman putmanb at georgetown.edu
Fri Aug 18 16:43:37 UTC 2023


This is an automated email from the git hooks/post-receive script.

putmanb pushed a commit to branch main
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=a228e1e10a3efc6d6ced97c628cd438343e64ee1

The following commit(s) were added to refs/heads/main by this push:
     new a228e1e10 Remove some test scope usage of JAXB.
a228e1e10 is described below

commit a228e1e10a3efc6d6ced97c628cd438343e64ee1
Author: Brent Putman <putmanb at georgetown.edu>
AuthorDate: Fri Aug 18 12:43:27 2023 -0400

    Remove some test scope usage of JAXB.
    
    Looks like older Santuario may have thrown JAXB ValidationException at
    some point, but no longer does. So we can now remove this dependency.
    
    This is related to OSJ-385 to update to Santuario 3.x.
---
 opensaml-xmlsec-impl/pom.xml                                        | 6 ------
 .../signature/support/tests/EnvelopedSignatureRSASSA_PSSTest.java   | 4 +---
 .../xmlsec/signature/support/tests/EnvelopedSignatureTest.java      | 4 +---
 .../opensaml/xmlsec/signature/support/tests/HMACSignatureTest.java  | 4 +---
 4 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/opensaml-xmlsec-impl/pom.xml b/opensaml-xmlsec-impl/pom.xml
index 3217b9dfa..a129a68a7 100644
--- a/opensaml-xmlsec-impl/pom.xml
+++ b/opensaml-xmlsec-impl/pom.xml
@@ -94,12 +94,6 @@
             <scope>test</scope>
         </dependency>
 
-        <dependency>
-            <groupId>jakarta.xml.bind</groupId>
-            <artifactId>jakarta.xml.bind-api</artifactId>
-            <scope>test</scope>
-        </dependency>
-
         <dependency>
             <groupId>org.cryptacular</groupId>
             <artifactId>cryptacular</artifactId>
diff --git a/opensaml-xmlsec-impl/src/test/java/org/opensaml/xmlsec/signature/support/tests/EnvelopedSignatureRSASSA_PSSTest.java b/opensaml-xmlsec-impl/src/test/java/org/opensaml/xmlsec/signature/support/tests/EnvelopedSignatureRSASSA_PSSTest.java
index 3513cb308..8fc0a6999 100644
--- a/opensaml-xmlsec-impl/src/test/java/org/opensaml/xmlsec/signature/support/tests/EnvelopedSignatureRSASSA_PSSTest.java
+++ b/opensaml-xmlsec-impl/src/test/java/org/opensaml/xmlsec/signature/support/tests/EnvelopedSignatureRSASSA_PSSTest.java
@@ -41,7 +41,6 @@ import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
 import org.w3c.dom.Element;
 
-import jakarta.xml.bind.ValidationException;
 import net.shibboleth.shared.primitive.LoggerFactory;
 import net.shibboleth.shared.xml.SerializeSupport;
 
@@ -86,11 +85,10 @@ public class EnvelopedSignatureRSASSA_PSSTest extends XMLObjectBaseTestCase {
      * Tests creating an enveloped signature and then verifying it.
      * 
      * @throws MarshallingException thrown if the XMLObject tree can not be marshalled
-     * @throws ValidationException ...
      * @throws SignatureException ...
      */
     @Test
-    public void testSigningAndVerification() throws MarshallingException, ValidationException, SignatureException {
+    public void testSigningAndVerification() throws MarshallingException, SignatureException {
         // BC is currently necessary for the RSASSA-PSS SHA-2 algos, even though it shouldn't be.
         final SecurityProviderTestSupport  providerSupport = new SecurityProviderTestSupport();
         try {
diff --git a/opensaml-xmlsec-impl/src/test/java/org/opensaml/xmlsec/signature/support/tests/EnvelopedSignatureTest.java b/opensaml-xmlsec-impl/src/test/java/org/opensaml/xmlsec/signature/support/tests/EnvelopedSignatureTest.java
index 7d92827f7..0ff23a772 100644
--- a/opensaml-xmlsec-impl/src/test/java/org/opensaml/xmlsec/signature/support/tests/EnvelopedSignatureTest.java
+++ b/opensaml-xmlsec-impl/src/test/java/org/opensaml/xmlsec/signature/support/tests/EnvelopedSignatureTest.java
@@ -48,7 +48,6 @@ import org.testng.annotations.Test;
 import org.w3c.dom.Document;
 import org.w3c.dom.Element;
 
-import jakarta.xml.bind.ValidationException;
 import net.shibboleth.shared.primitive.LoggerFactory;
 import net.shibboleth.shared.xml.SerializeSupport;
 import net.shibboleth.shared.xml.XMLParserException;
@@ -94,11 +93,10 @@ public class EnvelopedSignatureTest extends XMLObjectBaseTestCase {
      * Tests creating an enveloped signature and then verifying it.
      * 
      * @throws MarshallingException thrown if the XMLObject tree can not be marshalled
-     * @throws ValidationException ...
      * @throws SignatureException ...
      */
     @Test
-    public void testSigningAndVerification() throws MarshallingException, ValidationException, SignatureException {
+    public void testSigningAndVerification() throws MarshallingException, SignatureException {
         SignableSimpleXMLObject sxo = getXMLObjectWithSignature();
         Signature signature = sxo.getSignature();
 
diff --git a/opensaml-xmlsec-impl/src/test/java/org/opensaml/xmlsec/signature/support/tests/HMACSignatureTest.java b/opensaml-xmlsec-impl/src/test/java/org/opensaml/xmlsec/signature/support/tests/HMACSignatureTest.java
index 679c75027..7fafeb39c 100644
--- a/opensaml-xmlsec-impl/src/test/java/org/opensaml/xmlsec/signature/support/tests/HMACSignatureTest.java
+++ b/opensaml-xmlsec-impl/src/test/java/org/opensaml/xmlsec/signature/support/tests/HMACSignatureTest.java
@@ -51,7 +51,6 @@ import org.testng.annotations.Test;
 import org.w3c.dom.Document;
 import org.w3c.dom.Element;
 
-import jakarta.xml.bind.ValidationException;
 import net.shibboleth.shared.primitive.LoggerFactory;
 import net.shibboleth.shared.primitive.StringSupport;
 import net.shibboleth.shared.xml.ElementSupport;
@@ -113,11 +112,10 @@ public class HMACSignatureTest extends XMLObjectBaseTestCase {
      * Tests creating an enveloped signature and then verifying it.
      * 
      * @throws MarshallingException thrown if the XMLObject tree can not be marshalled
-     * @throws ValidationException thrown if signature validator fails to validate the signature
      * @throws SignatureException ...
      */
     @Test
-    public void testSigningAndVerificationNoOutputLength() throws MarshallingException, ValidationException, SignatureException {
+    public void testSigningAndVerificationNoOutputLength() throws MarshallingException, SignatureException {
         SignableSimpleXMLObject sxo = getXMLObjectWithSignature(false);
         Signature signature = sxo.getSignature();
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list