[java-idp-plugin-oidc-rp] branch main updated: Minor cleanups

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=c53cec0b96932024fa11b10964dde3a18d7a5224

The following commit(s) were added to refs/heads/main by this push:
     new c53cec0  Minor cleanups
c53cec0 is described below

commit c53cec0b96932024fa11b10964dde3a18d7a5224
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Aug 11 11:53:24 2023 +0100

    Minor cleanups
---
 .../idp/plugin/authn/oidc/rp/impl/ProcessEndUserClaims.java        | 2 +-
 .../authn/oidc/rp/impl/ValidateAuthenticationResponseResult.java   | 7 +++++--
 .../impl/AddAuthenticationContextClassReferencesHandler.java       | 1 -
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ProcessEndUserClaims.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ProcessEndUserClaims.java
index 83cca71..a9e4e65 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ProcessEndUserClaims.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ProcessEndUserClaims.java
@@ -130,7 +130,7 @@ public class ProcessEndUserClaims extends AbstractAuthenticationAction {
      * @param strategy the strategy to use.
      */
     public void setClaimSanitizationStrategy(@Nonnull final UnaryOperator<ClaimsSet> strategy) {
-    	checkSetterPreconditions();;
+    	checkSetterPreconditions();
         
         claimSanitizationStrategy = Constraint.isNotNull(strategy,
                 "ClaimSanatizationStrategy cannot be null");
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateAuthenticationResponseResult.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateAuthenticationResponseResult.java
index 41662dd..35bc499 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateAuthenticationResponseResult.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateAuthenticationResponseResult.java
@@ -73,8 +73,11 @@ public class ValidateAuthenticationResponseResult extends AbstractAuthentication
        
         if (!authenticationResponse.indicatesSuccess()) {
             final AuthenticationErrorResponse error = authenticationResponse.toErrorResponse();
-            log.error("{} OIDC Authentication Response contained an error from upstream OP '{}' : {}", 
-                    getLogPrefix(), authenticationContext.getAuthenticatingAuthority(),buildErrorResponseString(error));
+            if (log.isErrorEnabled()) {
+	            log.error("{} OIDC Authentication Response contained an error from upstream OP '{}' : {}", 
+	                    getLogPrefix(), authenticationContext.getAuthenticatingAuthority(),
+	                    buildErrorResponseString(error));
+            }
             // TODO: maybe more specific error, and or an error branch in the flow e.g. maybe a UI element?
             ActionSupport.buildEvent(profileRequestContext, EventIds.MESSAGE_PROC_ERROR);
         } else {
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddAuthenticationContextClassReferencesHandler.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddAuthenticationContextClassReferencesHandler.java
index 2af104b..f0a99dc 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddAuthenticationContextClassReferencesHandler.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddAuthenticationContextClassReferencesHandler.java
@@ -16,7 +16,6 @@ package net.shibboleth.idp.plugin.authn.oidc.rp.messaging.impl;
 
 import java.security.Principal;
 import java.util.List;
-import java.util.stream.Collectors;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.