[java-shib-attribute] 01/02: Fix some warnings.

Scott Cantor cantor.2 at osu.edu
Tue Aug 8 20:07:55 UTC 2023


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-attribute.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-attribute.git;a=commit;h=eb44c34c869f5d44cd3c496551638e5a49eb9902

commit eb44c34c869f5d44cd3c496551638e5a49eb9902
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Aug 8 16:07:21 2023 -0400

    Fix some warnings.
---
 .../shibboleth/idp/attribute/impl/ComputedPairwiseIdStore.java   | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/shib-attribute-impl/src/main/java/net/shibboleth/idp/attribute/impl/ComputedPairwiseIdStore.java b/shib-attribute-impl/src/main/java/net/shibboleth/idp/attribute/impl/ComputedPairwiseIdStore.java
index 411f8655b..cb8a8affd 100644
--- a/shib-attribute-impl/src/main/java/net/shibboleth/idp/attribute/impl/ComputedPairwiseIdStore.java
+++ b/shib-attribute-impl/src/main/java/net/shibboleth/idp/attribute/impl/ComputedPairwiseIdStore.java
@@ -84,10 +84,10 @@ public class ComputedPairwiseIdStore extends AbstractInitializableComponent impl
     @Nonnull private Map<String,Map<String,String>> exceptionMap;
 
     /** Optional source of salt for request. */
-    @Nullable BiFunction<ProfileRequestContext,PairwiseId,String> saltLookupStrategy;
+    @Nullable private BiFunction<ProfileRequestContext,PairwiseId,String> saltLookupStrategy;
     
     /** Servlet request supplier. */
-    @Nullable NonnullSupplier<HttpServletRequest> httpServletRequestSupplier;
+    @Nullable private NonnullSupplier<HttpServletRequest> httpServletRequestSupplier;
         
     /** Constructor. */
     public ComputedPairwiseIdStore() {
@@ -285,7 +285,8 @@ public class ComputedPairwiseIdStore extends AbstractInitializableComponent impl
     
         final byte[] effectiveSalt = getEffectiveSalt(pid);
         if (effectiveSalt == null) {
-            log.warn("Pairwise ID generation blocked for relying party ({}), no salt available", pid.getRecipientEntityID());
+            log.warn("Pairwise ID generation blocked for relying party ({}), no salt available",
+                    pid.getRecipientEntityID());
             throw new IOException("Pairwise ID generation blocked due to absence of salt");
         }
         
@@ -296,7 +297,7 @@ public class ComputedPairwiseIdStore extends AbstractInitializableComponent impl
             md.update(sourceId.getBytes());
             md.update((byte) '!');
 
-            final byte digestedEffectiveSalt[] = md.digest(effectiveSalt);
+            final byte[] digestedEffectiveSalt = md.digest(effectiveSalt);
             assert digestedEffectiveSalt!=null;
             if (encoding == Encoding.BASE32) {
                 pid.setPairwiseId(Base32Support.encode(digestedEffectiveSalt, Base32Support.UNCHUNKED));

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list