[java-identity-provider] branch main updated: Add ParameterName annotations to factory methods.

Scott Cantor cantor.2 at osu.edu
Wed Aug 2 20:00:21 UTC 2023


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=d22a6006a91b013300eea3caab59656321da5503

The following commit(s) were added to refs/heads/main by this push:
     new d22a6006a Add ParameterName annotations to factory methods.
d22a6006a is described below

commit d22a6006a91b013300eea3caab59656321da5503
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Aug 2 16:00:17 2023 -0400

    Add ParameterName annotations to factory methods.
---
 .../net/shibboleth/idp/profile/ScriptedAction.java  | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/idp-profile-api/src/main/java/net/shibboleth/idp/profile/ScriptedAction.java b/idp-profile-api/src/main/java/net/shibboleth/idp/profile/ScriptedAction.java
index 620b3c2d2..466395518 100644
--- a/idp-profile-api/src/main/java/net/shibboleth/idp/profile/ScriptedAction.java
+++ b/idp-profile-api/src/main/java/net/shibboleth/idp/profile/ScriptedAction.java
@@ -26,6 +26,7 @@ import org.opensaml.profile.action.EventIds;
 import org.opensaml.profile.context.ProfileRequestContext;
 import org.slf4j.Logger;
 
+import net.shibboleth.shared.annotation.ParameterName;
 import net.shibboleth.shared.annotation.constraint.NotEmpty;
 import net.shibboleth.shared.component.ComponentInitializationException;
 import net.shibboleth.shared.primitive.LoggerFactory;
@@ -124,8 +125,9 @@ public class ScriptedAction extends AbstractProfileAction {
      * @throws IOException if the file doesn't exist.
      * @throws ComponentInitializationException if the scripting initialization fails
      */
-    public static ScriptedAction resourceScript(@Nonnull @NotEmpty final String engineName,
-            @Nonnull final Resource resource)
+    @Nonnull public static ScriptedAction resourceScript(
+            @Nonnull @NotEmpty @ParameterName(name="engineName") final String engineName,
+            @Nonnull @ParameterName(name="resource") final Resource resource)
             throws ScriptException, IOException, ComponentInitializationException {
         final EvaluableScript script = new EvaluableScript();
         script.setEngineName(engineName);
@@ -143,8 +145,9 @@ public class ScriptedAction extends AbstractProfileAction {
      * @throws IOException if the file doesn't exist.
      * @throws ComponentInitializationException if the scripting initialization fails
      */
-    public static ScriptedAction resourceScript(@Nonnull final Resource resource)
-            throws ScriptException, IOException, ComponentInitializationException {
+    @Nonnull public static ScriptedAction resourceScript(
+            @Nonnull @ParameterName(name="resource") final Resource resource)
+                    throws ScriptException, IOException, ComponentInitializationException {
         return resourceScript(DEFAULT_ENGINE, resource);
     }
 
@@ -157,8 +160,10 @@ public class ScriptedAction extends AbstractProfileAction {
      * @throws ScriptException if the compile fails
      * @throws ComponentInitializationException if the scripting initialization fails
      */
-    public static ScriptedAction inlineScript(@Nonnull @NotEmpty final String engineName,
-            @Nonnull @NotEmpty final String scriptSource) throws ScriptException, ComponentInitializationException {
+    @Nonnull public static ScriptedAction inlineScript(
+            @Nonnull @NotEmpty @ParameterName(name="engineName") final String engineName,
+            @Nonnull @NotEmpty @ParameterName(name="scriptSource") final String scriptSource)
+                    throws ScriptException, ComponentInitializationException {
         final EvaluableScript script = new EvaluableScript();
                 script.setEngineName(engineName);
                 script.setScript(scriptSource);
@@ -174,7 +179,9 @@ public class ScriptedAction extends AbstractProfileAction {
      * @throws ScriptException if the compile fails
      * @throws ComponentInitializationException if the scripting initialization fails
      */
-    public static ScriptedAction inlineScript(@Nonnull @NotEmpty final String scriptSource) throws ScriptException, ComponentInitializationException {
+    @Nonnull public static ScriptedAction inlineScript(
+            @Nonnull @NotEmpty @ParameterName(name="scriptSource") final String scriptSource)
+                    throws ScriptException, ComponentInitializationException {
         return inlineScript(DEFAULT_ENGINE, scriptSource);
     }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list