[java-identity-provider] branch main updated: IDP-2094 Installer appears to loop on new installs after asking for target dir

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=16f81e1c95c1948f3e0d58ed0296ee0f2adc6607

The following commit(s) were added to refs/heads/main by this push:
     new 16f81e1c9 IDP-2094 Installer appears to loop on new installs after asking for target dir
16f81e1c9 is described below

commit 16f81e1c95c1948f3e0d58ed0296ee0f2adc6607
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Wed Apr 26 15:57:10 2023 +0100

    IDP-2094 Installer appears to loop on new installs after asking for target dir
    
    https://shibboleth.atlassian.net/browse/IDP-2094
    
    Fix broken null warning/error handling code
---
 .../java/net/shibboleth/idp/installer/InstallerPropertiesImpl.java  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/idp-installer/src/main/java/net/shibboleth/idp/installer/InstallerPropertiesImpl.java b/idp-installer/src/main/java/net/shibboleth/idp/installer/InstallerPropertiesImpl.java
index cd43968e0..12ba8d382 100644
--- a/idp-installer/src/main/java/net/shibboleth/idp/installer/InstallerPropertiesImpl.java
+++ b/idp-installer/src/main/java/net/shibboleth/idp/installer/InstallerPropertiesImpl.java
@@ -361,9 +361,9 @@ public class InstallerPropertiesImpl extends AbstractInitializableComponent impl
             defTarget = baseDir.toAbsolutePath().toString();
             assert defTarget!=null;
         }
-        final Path targetDir= Path.of(getValue(TARGET_DIR, "Installation Directory:", () -> defTarget));
-        assert targetDir != null;
-        return targetDir;
+        final Path td = targetDir = Path.of(getValue(TARGET_DIR, "Installation Directory:", () -> defTarget));
+        assert td != null;
+        return td;
     }
 
     /**  {@inheritDoc} */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.