[JIRA] (JSSH-27) Implement an ensureId method to help with nullability annotation

Rod Widdowson (Jira) jira at shibboleth.atlassian.net
Tue Apr 25 14:48:58 UTC 2023


Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSSH-27 ( https://shibboleth.atlassian.net/browse/JSSH-27?atlOrigin=eyJpIjoiM2Y2OTI4MzI1ZDNmNGE5YmFkYjIzZGEyZDUyOWM4YmQiLCJwIjoiaiJ9 )

Re: Implement an ensureId method to help with nullability annotation ( https://shibboleth.atlassian.net/browse/JSSH-27?atlOrigin=eyJpIjoiM2Y2OTI4MzI1ZDNmNGE5YmFkYjIzZGEyZDUyOWM4YmQiLCJwIjoiaiJ9 )

For instance

net.shibboleth.idp.saml.metadata.impl.MetadataResolverServiceGaugeSet.MetadataResolverServiceGaugeSet()

Has an example when it might be useful to have the ensureId on an interface but

* It would end up adding a null as a key to Map which is probably illegal
* I’m unconvinced that it is a good case (or even a case at all) for adding anything to any Interface

( https://shibboleth.atlassian.net/browse/JSSH-27#add-comment?atlOrigin=eyJpIjoiM2Y2OTI4MzI1ZDNmNGE5YmFkYjIzZGEyZDUyOWM4YmQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-27#add-comment?atlOrigin=eyJpIjoiM2Y2OTI4MzI1ZDNmNGE5YmFkYjIzZGEyZDUyOWM4YmQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100223- sha1:cdc0af3 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/a71a4ff9/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-7f67074f-ab97-4a0e-ac5d-1b4506cf91fb
Type: image/png
Size: 302 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/a71a4ff9/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-e6ddd137-1337-41e3-8b58-51d33a7f39d6
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/a71a4ff9/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-845ec58a-b5ae-472d-b6c8-7ed1db012d79
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/a71a4ff9/attachment-0005.png>


More information about the commits mailing list