[java-shib-shared] 02/02: JSSH-28 Consider using IllegalStateException in component lifecycle

Rod Widdowson rdw at steadingsoftware.com
Tue Apr 25 14:39:25 UTC 2023


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-shared.git;a=commit;h=c4a5c3c7bfe17f4dbe0d88194f76ef590e7abcb3

commit c4a5c3c7bfe17f4dbe0d88194f76ef590e7abcb3
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Tue Apr 25 15:36:05 2023 +0100

    JSSH-28 Consider using IllegalStateException in component lifecycle
    
    https://shibboleth.atlassian.net/jira/software/c/projects/JSSH/issues/JSSH-28
    
    Fix Tests
    
    Failures which used to be ConstraintException are now illegalStateException
---
 .../shared/servlet/impl/HttpServletRequestResponseContextTest.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/shib-networking/src/test/java/net/shibboleth/shared/servlet/impl/HttpServletRequestResponseContextTest.java b/shib-networking/src/test/java/net/shibboleth/shared/servlet/impl/HttpServletRequestResponseContextTest.java
index 98ac9636..83d3f42f 100644
--- a/shib-networking/src/test/java/net/shibboleth/shared/servlet/impl/HttpServletRequestResponseContextTest.java
+++ b/shib-networking/src/test/java/net/shibboleth/shared/servlet/impl/HttpServletRequestResponseContextTest.java
@@ -56,7 +56,7 @@ public class HttpServletRequestResponseContextTest {
         HttpServletRequestResponseContext.clearCurrent();
     }
     
-    @Test(expectedExceptions=ConstraintViolationException.class)
+    @Test(expectedExceptions= {ConstraintViolationException.class, IllegalStateException.class} )
     public void testRequestNoLoad() {
         Assert.assertNull(HttpServletRequestResponseContext.getRequest()); 
         Assert.assertNull(HttpServletRequestResponseContext.getResponse()); 
@@ -87,7 +87,7 @@ public class HttpServletRequestResponseContextTest {
     }
 
     
-    @Test(expectedExceptions=ConstraintViolationException.class)
+    @Test(expectedExceptions= {ConstraintViolationException.class, IllegalStateException.class} )
     public void testResponseNoLoad() {
         Assert.assertNull(HttpServletRequestResponseContext.getRequest()); 
         Assert.assertNull(HttpServletRequestResponseContext.getResponse()); 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list