[JIRA] (IDP-2092) Consider adding the Guava annotations to our null checking

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiYjMyYWQ2YzVkYTUxNDZhNDk0NGU5NDkwNTgxNDAwZmQiLCJwIjoiaiJ9 ) / Task ( https://shibboleth.atlassian.net/browse/IDP-2092?atlOrigin=eyJpIjoiYjMyYWQ2YzVkYTUxNDZhNDk0NGU5NDkwNTgxNDAwZmQiLCJwIjoiaiJ9 ) IDP-2092 ( https://shibboleth.atlassian.net/browse/IDP-2092?atlOrigin=eyJpIjoiYjMyYWQ2YzVkYTUxNDZhNDk0NGU5NDkwNTgxNDAwZmQiLCJwIjoiaiJ9 ) Consider adding the Guava annotations to our null checking ( https://shibboleth.atlassian.net/browse/IDP-2092?atlOrigin=eyJpIjoiYjMyYWQ2YzVkYTUxNDZhNDk0NGU5NDkwNTgxNDAwZmQiLCJwIjoiaiJ9 )

Issue Type: Task Affects Versions: 5.0.0 Assignee: Unassigned Created: 25/Apr/23 10:29 AM Fix Versions: 5.0.0 Priority: Trivial Reporter: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 )

Exbedded from FESF-2069

I’ve just spotted that the google code has yet another annotation set : e.g.
MoreObjects.ToStringHelper#add(String name, @CheckForNull Object value)

That annotation means that the code will throw if given a null so can be clumped (for our purposes with @NonNull

( https://shibboleth.atlassian.net/browse/IDP-2092#add-comment?atlOrigin=eyJpIjoiYjMyYWQ2YzVkYTUxNDZhNDk0NGU5NDkwNTgxNDAwZmQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2092#add-comment?atlOrigin=eyJpIjoiYjMyYWQ2YzVkYTUxNDZhNDk0NGU5NDkwNTgxNDAwZmQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100223- sha1:cdc0af3 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/7588f26c/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-11626e28-eee1-4cad-a875-6a3be1cc7a98
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/7588f26c/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-71a9403c-05cc-4340-8741-f54567cc1caf
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/7588f26c/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-c947d156-2f3d-41de-bb7d-cfc04941d1b7
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/7588f26c/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-1dd0a7fd-acaa-4575-9951-a10f13d48e9e
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/7588f26c/attachment-0007.png>