[java-idp-plugin-oidc-rp] branch main updated: Fix checkstyle and some minor Javadoc

Phil Smart philip.smart at jisc.ac.uk
Tue Apr 25 13:10:10 UTC 2023


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=320d0a11b5d201bdae571b6429d4047488cf9c0c

The following commit(s) were added to refs/heads/main by this push:
     new 320d0a1  Fix checkstyle and some minor Javadoc
320d0a1 is described below

commit 320d0a11b5d201bdae571b6429d4047488cf9c0c
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Tue Apr 25 14:10:08 2023 +0100

    Fix checkstyle and some minor Javadoc
---
 .../idp/plugin/authn/oidc/rp/principal}/package-info.java    |  4 ++--
 .../rp/decoding/impl/DefaultAccessTokenResponseDecoder.java  |  2 +-
 .../rp/decoding/impl/DefaultUserInfoResponseDecoder.java     |  4 ++--
 .../plugin/authn/oidc/rp/impl/AuthorizationController.java   |  4 +++-
 .../idp/plugin/authn/oidc/rp/impl/ProcessEndUserClaims.java  |  5 ++++-
 .../oidc/rp/impl/ValidateExternalAuthenticationContext.java  | 12 ++++++------
 .../authn/oidc/rp/impl/ValidateOAuthAccessTokenResponse.java |  6 +++---
 .../authn/oidc/rp/impl/ValidateOIDCAuthentication.java       |  7 ++++---
 .../idp/plugin/authn/oidc/rp/impl/ValidateResponseState.java |  1 -
 .../idp/plugin/authn/oidc/rp/impl/ValidateTokenClaims.java   |  2 +-
 .../authn/oidc/rp/impl/ValidateUserInfoJSONObjectClaims.java |  5 +++--
 .../rp/messaging/impl/AddResponseTypeAndModeHandler.java     |  2 ++
 .../idp/plugin/authn/oidc/rp/metadata/impl/package-info.java |  2 +-
 .../impl/RelyingPartyProxySigningParametersResolver.java     |  2 +-
 .../idp/plugin/authn/oidc/rp/security/impl/package-info.java |  2 +-
 .../OIDCRelyingParty/oidc-relying-party-authn-beans.xml      |  2 +-
 .../shibboleth/idp/plugin/authn/oidc/rp/module.properties    |  2 --
 .../shibboleth/idp/plugin/authn/oidc/rp/plugin.properties    |  2 --
 18 files changed, 35 insertions(+), 31 deletions(-)

diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/package-info.java b/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/principal/package-info.java
similarity index 88%
copy from idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/package-info.java
copy to idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/principal/package-info.java
index cb105ef..283c73a 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/package-info.java
+++ b/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/principal/package-info.java
@@ -16,6 +16,6 @@
  */
 
 /**
- * Package that RP specific security functions
+ * OpenID Connect principals.
  */
-package net.shibboleth.idp.plugin.authn.oidc.rp.security.impl;
\ No newline at end of file
+package net.shibboleth.idp.plugin.authn.oidc.rp.principal;
\ No newline at end of file
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/decoding/impl/DefaultAccessTokenResponseDecoder.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/decoding/impl/DefaultAccessTokenResponseDecoder.java
index 3bdf42c..3b03252 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/decoding/impl/DefaultAccessTokenResponseDecoder.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/decoding/impl/DefaultAccessTokenResponseDecoder.java
@@ -75,7 +75,7 @@ public class DefaultAccessTokenResponseDecoder extends AbstractJSONResponseDecod
             
             if (httpStatusCode != HttpStatus.SC_OK) {
                 return TokenErrorResponse.parse(new JSONObject(tokenResponseAsMap));                
-            } else if (httpResponse.getEntity() == null || httpResponse.getEntity().getContent() == null) {                
+            } else if (httpResponse.getEntity() == null || httpResponse.getEntity().getContent() == null) {
                 log.warn("HTTP response does not contain a message entity, nothing to decode, status '{}'", 
                         httpStatusCode);
                 return null;
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/decoding/impl/DefaultUserInfoResponseDecoder.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/decoding/impl/DefaultUserInfoResponseDecoder.java
index 22e80ca..35f93a3 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/decoding/impl/DefaultUserInfoResponseDecoder.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/decoding/impl/DefaultUserInfoResponseDecoder.java
@@ -54,7 +54,7 @@ public class DefaultUserInfoResponseDecoder extends AbstractJSONResponseDecoderF
     /** Class logger. */
     @Nonnull private final Logger log = LoggerFactory.getLogger(DefaultUserInfoResponseDecoder.class);    
     
- // CheckStyle: CyclomaticComplexity OFF
+ // Checkstyle: CyclomaticComplexity|ReturnCount|MethodLength OFF
     @Override
     public UserInfoResponse apply(@Nonnull final HttpResponse httpResponse) {
         
@@ -130,5 +130,5 @@ public class DefaultUserInfoResponseDecoder extends AbstractJSONResponseDecoderF
         return null;
         
     }
- // CheckStyle: CyclomaticComplexity ON
+ // Checkstyle: CyclomaticComplexity|ReturnCount|MethodLength ON
 }
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthorizationController.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthorizationController.java
index ff3df3b..b799f4a 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthorizationController.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthorizationController.java
@@ -225,6 +225,8 @@ public class AuthorizationController extends AbstractInitializableComponent {
              
     }
     
+    
+ // Checkstyle: CyclomaticComplexity|MethodLength OFF
     /**
      * Callback endpoint to accept the authorization response.
      * 
@@ -310,6 +312,6 @@ public class AuthorizationController extends AbstractInitializableComponent {
         ExternalAuthentication.finishExternalAuthentication(key, httpRequest, httpResponse);
         
     }
-    
+ // Checkstyle: CyclomaticComplexity|MethodLength ON  
     
 }
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ProcessEndUserClaims.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ProcessEndUserClaims.java
index cbb760c..1a9b998 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ProcessEndUserClaims.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ProcessEndUserClaims.java
@@ -197,7 +197,8 @@ public class ProcessEndUserClaims extends AbstractOIDCAuthenticationResponseActi
         userInfoResponseContextLookupStrategy = Constraint.isNotNull(strategy,
                 "UserInfoResponseContext lookup strategy cannot be null");
     }
-    
+  
+ // Checkstyle: CyclomaticComplexity OFF
     @Override protected boolean doPreExecute(@Nonnull final ProfileRequestContext profileRequestContext,
             @Nonnull final AuthenticationContext authenticationContext) {
         
@@ -253,6 +254,8 @@ public class ProcessEndUserClaims extends AbstractOIDCAuthenticationResponseActi
         return true;
     }
     
+ // Checkstyle: CyclomaticComplexity ON
+    
     @Override protected void doExecute(@Nonnull final ProfileRequestContext profileRequestContext,
             @Nonnull final AuthenticationContext authenticationContext) { 
         
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateExternalAuthenticationContext.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateExternalAuthenticationContext.java
index 6bf0cc9..11c0631 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateExternalAuthenticationContext.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateExternalAuthenticationContext.java
@@ -20,19 +20,19 @@ package net.shibboleth.idp.plugin.authn.oidc.rp.impl;
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
-import net.shibboleth.idp.authn.AbstractAuthenticationAction;
-import net.shibboleth.idp.authn.AuthnEventIds;
-import net.shibboleth.idp.authn.context.AuthenticationContext;
-import net.shibboleth.idp.authn.context.ExternalAuthenticationContext;
-
 import org.opensaml.profile.action.ActionSupport;
 import org.opensaml.profile.action.EventIds;
 import org.opensaml.profile.context.ProfileRequestContext;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import net.shibboleth.idp.authn.AbstractAuthenticationAction;
+import net.shibboleth.idp.authn.AuthnEventIds;
+import net.shibboleth.idp.authn.context.AuthenticationContext;
+import net.shibboleth.idp.authn.context.ExternalAuthenticationContext;
+
 /**
- * An action that checks for an {@link ExternalAuthenticationContext} for a signaled event via the
+ * An action that checks for a {@link ExternalAuthenticationContext} for a signalled event via the
  * {@link ExternalAuthenticationContext#getAuthnError()} method.
  *  
  * @event {@link EventIds#PROCEED_EVENT_ID}
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateOAuthAccessTokenResponse.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateOAuthAccessTokenResponse.java
index 0a19967..3396fdf 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateOAuthAccessTokenResponse.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateOAuthAccessTokenResponse.java
@@ -79,6 +79,7 @@ public class ValidateOAuthAccessTokenResponse extends AbstractOIDCAuthentication
                 "TokenResponseContext lookup strategy cannot be null");
     }
     
+ // Checkstyle: CyclomaticComplexity OFF
     /** {@inheritDoc} */
     @Override protected void doExecute(@Nonnull final ProfileRequestContext profileRequestContext,
             @Nonnull final AuthenticationContext authenticationContext) {
@@ -130,9 +131,8 @@ public class ValidateOAuthAccessTokenResponse extends AbstractOIDCAuthentication
                 ActionSupport.buildEvent(profileRequestContext, OidcEventIds.INVALID_ACCESS_TOKEN);
                 return;
             }
-        }
-
-        
+        }   
     }
+ // Checkstyle: CyclomaticComplexity ON
 
 }
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateOIDCAuthentication.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateOIDCAuthentication.java
index 92f0052..b42b2cd 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateOIDCAuthentication.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateOIDCAuthentication.java
@@ -219,6 +219,7 @@ public class ValidateOIDCAuthentication extends AbstractValidationAction {
 
     }
 
+ // Checkstyle: CyclomaticComplexity|ReturnCount|MethodLength OFF    
     @Override
     protected boolean doPreExecute(@Nonnull final ProfileRequestContext profileRequestContext, 
             @Nonnull final AuthenticationContext authenticationContext) {
@@ -290,9 +291,9 @@ public class ValidateOIDCAuthentication extends AbstractValidationAction {
             ActionSupport.buildEvent(profileRequestContext, EventIds.INVALID_PROFILE_CTX);
             return false;
         }
-
         return true;
     }
+ // Checkstyle: CyclomaticComplexity|ReturnCount|MethodLength ON
 
     /** {@inheritDoc} */
     @Override
@@ -357,7 +358,7 @@ public class ValidateOIDCAuthentication extends AbstractValidationAction {
         
     }
 
-   
+// Checkstyle: CyclomaticComplexity OFF 
     @Override
     protected Subject populateSubject(@Nonnull final Subject subject) {   
                 
@@ -391,7 +392,6 @@ public class ValidateOIDCAuthentication extends AbstractValidationAction {
             }
             
         }
-
         // TODO What type of subject?  switch on subject_types_supported and subject_type.       
         subject.getPrincipals().add(
                 new OIDCSubjectIdentifierPrincipal(endUserContext.getUnprocessedIdTokenClaims().getSubject()));
@@ -409,6 +409,7 @@ public class ValidateOIDCAuthentication extends AbstractValidationAction {
              
         return subject;
     }
+    // Checkstyle: CyclomaticComplexity ON
     
     /**
      * Construct a populated {@link ProxyAuthenticationPrincipal} based on the upstream OP (the
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateResponseState.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateResponseState.java
index 8095b8b..5f3ba96 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateResponseState.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateResponseState.java
@@ -26,7 +26,6 @@ import org.slf4j.LoggerFactory;
 
 import net.shibboleth.idp.authn.AuthnEventIds;
 import net.shibboleth.idp.authn.context.AuthenticationContext;
-import net.shibboleth.oidc.profile.core.OidcEventIds;
 import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
 
 /**
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateTokenClaims.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateTokenClaims.java
index 8242787..38cf409 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateTokenClaims.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateTokenClaims.java
@@ -47,7 +47,7 @@ import net.shibboleth.utilities.java.support.logic.Constraint;
 /**
  * Action that validates the claims of a JWT using the supplied 
  * {@link ClaimsValidator claims validator}. The verifier <b>must</b> be thread-safe and validate, at
- * minimum the claims set against the OpenID Connect core 1.0 section 3.1.3.7 specification. 
+ * minimum, the claims set against the OpenID Connect core 1.0 section 3.1.3.7 specification. 
  * 
  * 
  * @pre <pre>ProfileRequestContext.getSubcontext(AuthenticationContext.class, false) != null</pre> 
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateUserInfoJSONObjectClaims.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateUserInfoJSONObjectClaims.java
index ec4e78a..919bbb3 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateUserInfoJSONObjectClaims.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/ValidateUserInfoJSONObjectClaims.java
@@ -136,7 +136,7 @@ public class ValidateUserInfoJSONObjectClaims extends AbstractAuthenticationActi
                 log.debug("{} AccessTokenResponseContext did not contain an id_token with accessible claims, "
                         + "possibly still encrypted", 
                         getLogPrefix());
-                ActionSupport.buildEvent(profileRequestContext, EventIds.INVALID_PROFILE_CTX);
+                ActionSupport.buildEvent(profileRequestContext, OidcEventIds.INVALID_ID_TOKEN);
                 return false;
             }
         } catch (final ParseException e) {
@@ -181,7 +181,8 @@ public class ValidateUserInfoJSONObjectClaims extends AbstractAuthenticationActi
      * 
      * @param response the UserInfo response
      * 
-     * @return the UserInfo claims. Return {@code null} if not found, wrong response type, or there was a parsing exception
+     * @return the UserInfo claims. Return {@code null} if not found, wrong response type, or there was a parsing 
+     *              exception
      */
     @Nullable private ClaimsSet resolveClaimsSet(@Nonnull final UserInfoResponse response) {
         if (!response.indicatesSuccess()) {
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddResponseTypeAndModeHandler.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddResponseTypeAndModeHandler.java
index b5cf183..c6adf74 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddResponseTypeAndModeHandler.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddResponseTypeAndModeHandler.java
@@ -165,6 +165,7 @@ public class AddResponseTypeAndModeHandler extends AbstractOIDCAuthenticationReq
         }
     }
     
+ // Checkstyle: ReturnCount OFF
     /**
      * Parse the response_mode into a known {@link ResponseMode}.
      * 
@@ -196,6 +197,7 @@ public class AddResponseTypeAndModeHandler extends AbstractOIDCAuthenticationReq
             return null;
         }
     }
+ // Checkstyle: ReturnCount ON
     
 
 }
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/metadata/impl/package-info.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/metadata/impl/package-info.java
index 394ece5..4432155 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/metadata/impl/package-info.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/metadata/impl/package-info.java
@@ -16,6 +16,6 @@
  */
 
 /**
- * Package that OpenID Provider and RelyingParty metadata lookup functions
+ * Package that OpenID Provider and RelyingParty metadata lookup functions.
  */
 package net.shibboleth.idp.plugin.authn.oidc.rp.metadata.impl;
\ No newline at end of file
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/RelyingPartyProxySigningParametersResolver.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/RelyingPartyProxySigningParametersResolver.java
similarity index 99%
rename from idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/RelyingPartyProxySigningParametersResolver.java
rename to idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/RelyingPartyProxySigningParametersResolver.java
index f239b03..1533350 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/RelyingPartyProxySigningParametersResolver.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/RelyingPartyProxySigningParametersResolver.java
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package net.shibboleth.idp.plugin.authn.oidc.rp.impl;
+package net.shibboleth.idp.plugin.authn.oidc.rp.security.impl;
 
 import java.util.ArrayList;
 import java.util.List;
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/package-info.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/package-info.java
index cb105ef..a6fec15 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/package-info.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/package-info.java
@@ -16,6 +16,6 @@
  */
 
 /**
- * Package that RP specific security functions
+ * Package that RP specific security functions.
  */
 package net.shibboleth.idp.plugin.authn.oidc.rp.security.impl;
\ No newline at end of file
diff --git a/idp-oidc-rp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/OIDCRelyingParty/oidc-relying-party-authn-beans.xml b/idp-oidc-rp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/OIDCRelyingParty/oidc-relying-party-authn-beans.xml
index 38657b6..046f061 100644
--- a/idp-oidc-rp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/OIDCRelyingParty/oidc-relying-party-authn-beans.xml
+++ b/idp-oidc-rp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/OIDCRelyingParty/oidc-relying-party-authn-beans.xml
@@ -177,7 +177,7 @@
         p:activationCondition-ref="shibboleth.authn.oidc.rp.SignRequestObjectProxyCondition" />
 
     <bean id="shibboleth.authn.oidc.rp.RequestObjectSignatureSigningParametersResolver"
-        class="net.shibboleth.idp.plugin.authn.oidc.rp.impl.RelyingPartyProxySigningParametersResolver"
+        class="net.shibboleth.idp.plugin.authn.oidc.rp.security.impl.RelyingPartyProxySigningParametersResolver"
         p:providerMetadataAlgorithmLookupStrategy-ref="shibboleth.authn.oidc.rp.RequestObjectSupportedSignatureSigningAlgorithms" />
 
     <bean id="shibboleth.authn.oidc.rp.RequestObjectSupportedSignatureSigningAlgorithms" scope="prototype"
diff --git a/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/module.properties b/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/module.properties
index 7322bac..5986923 100644
--- a/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/module.properties
+++ b/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/module.properties
@@ -1,5 +1,3 @@
-# Example Properties defining an authentication module.
-
 # Class to Module ID mappings
 net.shibboleth.idp.plugin.authn.oidc.rp.OIDCRPModule = idp.authn.oidc.RP
 
diff --git a/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/plugin.properties b/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/plugin.properties
index beadaba..84b9ca4 100644
--- a/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/plugin.properties
+++ b/idp-oidc-rp-impl/src/main/resources/net/shibboleth/idp/plugin/authn/oidc/rp/plugin.properties
@@ -1,5 +1,3 @@
-# Example properties defining this plugin
-
 plugin.id = net.shibboleth.idp.plugin.authn.oidc.rp
 # Only used when package manifest is not available
 plugin.version = 0.10.0

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list