[JIRA] (JSSH-27) Implement an ensureId method to help with nullability annotation

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on JSSH-27 ( https://shibboleth.atlassian.net/browse/JSSH-27?atlOrigin=eyJpIjoiMDJlMTM4NzA3NjAyNDE2NDgzNTRiMjkxNWFjODFiODIiLCJwIjoiaiJ9 )

Re: Implement an ensureId method to help with nullability annotation ( https://shibboleth.atlassian.net/browse/JSSH-27?atlOrigin=eyJpIjoiMDJlMTM4NzA3NjAyNDE2NDgzNTRiMjkxNWFjODFiODIiLCJwIjoiaiJ9 )

That makes sense to me. The purpose of the protected was to expose this point, and it does seem like you’ve found enough evidence that it would be useful to change that to public. I suggest you go ahead and do that.

I’d prefer to leave it out of the interface unless we find this is insufficient; it’s far more invasive and although I don’t think there’s much code out there that would be affected by a change to the interface one never knows so if we can be cautious for now I think that’s best. Of course if we did add to the interface we’ll already have done the implementation work and there wouldn’t be an additional change there.

( https://shibboleth.atlassian.net/browse/JSSH-27#add-comment?atlOrigin=eyJpIjoiMDJlMTM4NzA3NjAyNDE2NDgzNTRiMjkxNWFjODFiODIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-27#add-comment?atlOrigin=eyJpIjoiMDJlMTM4NzA3NjAyNDE2NDgzNTRiMjkxNWFjODFiODIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100223- sha1:cdc0af3 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/70bcdebd/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-db30228e-1ccf-4b88-9bac-8de1b9110383
Type: image/png
Size: 302 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/70bcdebd/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-b5c1b07d-3c5c-4d6e-bb5a-751fd23e1451
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/70bcdebd/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-7406f38d-3b1d-4ce3-bad7-11c290be7c99
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230425/70bcdebd/attachment-0005.png>