[JIRA] (JSSH-27) Implement an ensureId method to help with nullability annotation

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSSH-27 ( https://shibboleth.atlassian.net/browse/JSSH-27?atlOrigin=eyJpIjoiMjUwMGI4NzcyYjM2NDcwZTg2YWNlMzI0YjQ3ZDgyY2YiLCJwIjoiaiJ9 )

Re: Implement an ensureId method to help with nullability annotation ( https://shibboleth.atlassian.net/browse/JSSH-27?atlOrigin=eyJpIjoiMjUwMGI4NzcyYjM2NDcwZTg2YWNlMzI0YjQ3ZDgyY2YiLCJwIjoiaiJ9 )

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) you made this a protected method. Was there any motivation for this beyond wanting to make the impact as low as possible?

In (for instance) {{org.opensaml.storage.impl.client.JSONClientStorageServiceStore#save(ClientStorageService) }}at about line 112 I have a use for this being a public method.

( https://shibboleth.atlassian.net/browse/JSSH-27#add-comment?atlOrigin=eyJpIjoiMjUwMGI4NzcyYjM2NDcwZTg2YWNlMzI0YjQ3ZDgyY2YiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-27#add-comment?atlOrigin=eyJpIjoiMjUwMGI4NzcyYjM2NDcwZTg2YWNlMzI0YjQ3ZDgyY2YiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100223- sha1:77dfe11 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230424/b3abaeab/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-f081cf44-566c-4a96-b5aa-94d2639d52d3
Type: image/png
Size: 302 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230424/b3abaeab/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-e560cab3-b314-4cfb-b270-1055bcf1b7f9
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230424/b3abaeab/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-3ecfe5a6-c488-4a8d-a96b-56f87a704696
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230424/b3abaeab/attachment-0005.png>