[JIRA] (JSSH-28) Consider using IllegalStateException in component lifecycle

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *created* an issue

Shibboleth Shared - Java ( https://shibboleth.atlassian.net/browse/JSSH?atlOrigin=eyJpIjoiODhkMGU3YjBlOGIwNDNhNmExY2ZlNzEwNmM4NjcxYWEiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/JSSH-28?atlOrigin=eyJpIjoiODhkMGU3YjBlOGIwNDNhNmExY2ZlNzEwNmM4NjcxYWEiLCJwIjoiaiJ9 ) JSSH-28 ( https://shibboleth.atlassian.net/browse/JSSH-28?atlOrigin=eyJpIjoiODhkMGU3YjBlOGIwNDNhNmExY2ZlNzEwNmM4NjcxYWEiLCJwIjoiaiJ9 ) Consider using IllegalStateException in component lifecycle ( https://shibboleth.atlassian.net/browse/JSSH-28?atlOrigin=eyJpIjoiODhkMGU3YjBlOGIwNDNhNmExY2ZlNzEwNmM4NjcxYWEiLCJwIjoiaiJ9 )

Issue Type: Improvement Assignee: Unassigned Components: General Created: 24/Apr/23 7:03 AM Priority: Trivial Reporter: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 )

We have a couple of custom exception types, e.g., DestroyedComponentException , UninitializedComponentException , that extend RuntimeException (i.e., are unchecked) and are thrown when a component’s state is inappropriate for some method.

There’s a JDK-defined exception for this case ( IllegalStateException ) and we should consider using that instead or, alternatively, making our exceptions subclasses of the JDK one.

( https://shibboleth.atlassian.net/browse/JSSH-28#add-comment?atlOrigin=eyJpIjoiODhkMGU3YjBlOGIwNDNhNmExY2ZlNzEwNmM4NjcxYWEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-28#add-comment?atlOrigin=eyJpIjoiODhkMGU3YjBlOGIwNDNhNmExY2ZlNzEwNmM4NjcxYWEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100223- sha1:77dfe11 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230424/08ebbd46/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-98d3414a-3e37-43ea-b352-1cf44fc939c5
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230424/08ebbd46/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e2c8cc8a-abfe-4d07-be0f-0197b3998928
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230424/08ebbd46/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-aef8c60c-830f-4322-8492-1f1e8b4a570e
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230424/08ebbd46/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-268d634b-525b-4d67-97c3-afa794fb9bae
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230424/08ebbd46/attachment-0007.png>