[JIRA] (MDA-266) Rework module structure and packaging
Ian Young (Jira)
jira at shibboleth.atlassian.net
Fri Apr 21 11:35:59 UTC 2023
Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *reopened* an issue
Reopening this to make some more changes in the area of keylists.
Previously, the keylists were included as part of the main artifact. The initial MDA-266 ( https://shibboleth.atlassian.net/browse/MDA-266 ) Reopened change moved those into a single `mda-keylists-rsa`, which is good in that allowed for RSA vs. (in the future) potentially other key types in separate artifacts. However, the keylist resources are in `net/shibboleth/metadata/validate/x509`, which is where the classes in the main artifact also live. This is a bad idea because it's implicitly a split package.
So, we should move the resources into a new package so that there's no package split across artifacts. This will make us compatible with the Java module system and with JAR sealing.
I'm also inclined to elaborate this a bit more by putting the 512-bit and 1024-bit keylists, which I doubt are used in anger these days, into a different artifact again, say `mda-keylists-rsa-legacy`.
So:
Artifact `mda-keylists-rsa` using package `net.shibboleth.metadata.keylists.rsa`
Artifact `mda-keylists-rsa-legacy` using package `net.shibboleth.metadata.keylists.rsa.legacy`.
I think it's also worth considering moving the tests back into the main `mda-framework` module, unless they are genuinely specific to the individual resources.
Metadata Aggregator ( https://shibboleth.atlassian.net/browse/MDA?atlOrigin=eyJpIjoiMjU1OWQ1ODQzZGZlNDhiYTk4ZTI1OTRlOWIyNmI3ODEiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/MDA-266?atlOrigin=eyJpIjoiMjU1OWQ1ODQzZGZlNDhiYTk4ZTI1OTRlOWIyNmI3ODEiLCJwIjoiaiJ9 ) MDA-266 ( https://shibboleth.atlassian.net/browse/MDA-266?atlOrigin=eyJpIjoiMjU1OWQ1ODQzZGZlNDhiYTk4ZTI1OTRlOWIyNmI3ODEiLCJwIjoiaiJ9 ) Rework module structure and packaging ( https://shibboleth.atlassian.net/browse/MDA-266?atlOrigin=eyJpIjoiMjU1OWQ1ODQzZGZlNDhiYTk4ZTI1OTRlOWIyNmI3ODEiLCJwIjoiaiJ9 )
Change By: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) Resolution: Completed Status: Resolved Reopened
( https://shibboleth.atlassian.net/browse/MDA-266#add-comment?atlOrigin=eyJpIjoiMjU1OWQ1ODQzZGZlNDhiYTk4ZTI1OTRlOWIyNmI3ODEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-266#add-comment?atlOrigin=eyJpIjoiMjU1OWQ1ODQzZGZlNDhiYTk4ZTI1OTRlOWIyNmI3ODEiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100223- sha1:bddbaa2 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230421/ad932599/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-1f7ac7cd-bfeb-42c4-9c20-443a80429fec
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230421/ad932599/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-cbef9894-cef7-4065-8edc-d6d0ab09adb8
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230421/ad932599/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-6a619b7d-d32b-452e-ad93-94b2b94434eb
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230421/ad932599/attachment-0005.png>
More information about the commits
mailing list