[java-shib-attribute] branch main updated: Fix tests that were mutating via immutable collection API.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-attribute.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-attribute.git;a=commit;h=65608dbb07fdab399bd7d7399e8504145df0147e

The following commit(s) were added to refs/heads/main by this push:
     new 65608dbb0 Fix tests that were mutating via immutable collection API.
65608dbb0 is described below

commit 65608dbb07fdab399bd7d7399e8504145df0147e
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Apr 20 15:29:35 2023 -0400

    Fix tests that were mutating via immutable collection API.
---
 .../idp/attribute/filter/context/AttributeFilterContextTest.java    | 5 +++--
 .../attribute/filter/context/AttributeFilterWorkContextTest.java    | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/shib-attribute-filter-api/src/test/java/net/shibboleth/idp/attribute/filter/context/AttributeFilterContextTest.java b/shib-attribute-filter-api/src/test/java/net/shibboleth/idp/attribute/filter/context/AttributeFilterContextTest.java
index 150aa168d..ac861dc75 100644
--- a/shib-attribute-filter-api/src/test/java/net/shibboleth/idp/attribute/filter/context/AttributeFilterContextTest.java
+++ b/shib-attribute-filter-api/src/test/java/net/shibboleth/idp/attribute/filter/context/AttributeFilterContextTest.java
@@ -21,6 +21,7 @@ import java.util.Arrays;
 import java.util.List;
 
 import net.shibboleth.idp.attribute.IdPAttribute;
+import net.shibboleth.shared.collection.CollectionSupport;
 
 import org.opensaml.messaging.context.navigate.ChildContextLookup;
 import org.opensaml.saml.common.messaging.context.SAMLMetadataContext;
@@ -53,7 +54,7 @@ public class AttributeFilterContextTest {
         final AttributeFilterContext context = new AttributeFilterContext();
 
         final IdPAttribute attribute1 = new IdPAttribute("attribute1");
-        context.getPrefilteredIdPAttributes().put(attribute1.getId(), attribute1);
+        context.setPrefilteredIdPAttributes(CollectionSupport.singletonList(attribute1));
         Assert.assertEquals(context.getPrefilteredIdPAttributes().size(), 1);
         Assert.assertTrue(context.getPrefilteredIdPAttributes().containsKey("attribute1"));
         Assert.assertEquals(context.getPrefilteredIdPAttributes().get("attribute1"), attribute1);
@@ -79,7 +80,7 @@ public class AttributeFilterContextTest {
         final AttributeFilterContext context = new AttributeFilterContext();
 
         final IdPAttribute attribute1 = new IdPAttribute("attribute1");
-        context.getFilteredIdPAttributes().put(attribute1.getId(), attribute1);
+        context.setFilteredIdPAttributes(CollectionSupport.singletonList(attribute1));
         Assert.assertEquals(context.getFilteredIdPAttributes().size(), 1);
         Assert.assertTrue(context.getFilteredIdPAttributes().containsKey("attribute1"));
         Assert.assertEquals(context.getFilteredIdPAttributes().get("attribute1"), attribute1);
diff --git a/shib-attribute-filter-api/src/test/java/net/shibboleth/idp/attribute/filter/context/AttributeFilterWorkContextTest.java b/shib-attribute-filter-api/src/test/java/net/shibboleth/idp/attribute/filter/context/AttributeFilterWorkContextTest.java
index 0c532782b..0178a69c6 100644
--- a/shib-attribute-filter-api/src/test/java/net/shibboleth/idp/attribute/filter/context/AttributeFilterWorkContextTest.java
+++ b/shib-attribute-filter-api/src/test/java/net/shibboleth/idp/attribute/filter/context/AttributeFilterWorkContextTest.java
@@ -52,7 +52,7 @@ public class AttributeFilterWorkContextTest {
         
         final IdPAttribute attribute1 = new IdPAttribute("one");
         attribute1.setValues(Arrays.asList(aStringAttributeValue, bStringAttributeValue));
-        parent.getPrefilteredIdPAttributes().put(attribute1.getId(), attribute1);
+        parent.setPrefilteredIdPAttributes(CollectionSupport.singletonList(attribute1));
 
         context.addPermittedIdPAttributeValues("one", CollectionSupport.singletonList(aStringAttributeValue));
         Assert.assertEquals(context.getPermittedIdPAttributeValues().get("one").size(), 1);
@@ -98,8 +98,8 @@ public class AttributeFilterWorkContextTest {
         final AttributeFilterWorkContext context = parent.ensureSubcontext(AttributeFilterWorkContext.class);
 
         final IdPAttribute attribute1 = new IdPAttribute("one");
-        attribute1.setValues(Arrays.asList(aStringAttributeValue, bStringAttributeValue));
-        parent.getPrefilteredIdPAttributes().put(attribute1.getId(), attribute1);
+        attribute1.setValues(CollectionSupport.listOf(aStringAttributeValue, bStringAttributeValue));
+        parent.setPrefilteredIdPAttributes(CollectionSupport.singletonList(attribute1));
 
         context.addDeniedIdPAttributeValues("one", CollectionSupport.singletonList(aStringAttributeValue));
         Assert.assertEquals(context.getDeniedAttributeValues().get("one").size(), 1);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.