[java-idp-plugin-oidc-config] branch main updated: JCOMOIDC-66 - Review ProfileConfiguration interfaces and concrete classes

Phil Smart philip.smart at jisc.ac.uk
Wed Apr 19 14:14:34 UTC 2023


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-config.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-config.git;a=commit;h=d077eceb9ffc9306fa46c892e4af423fe885b90a

The following commit(s) were added to refs/heads/main by this push:
     new d077ece  JCOMOIDC-66 - Review ProfileConfiguration interfaces and concrete classes
d077ece is described below

commit d077eceb9ffc9306fa46c892e4af423fe885b90a
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Wed Apr 19 15:14:32 2023 +0100

    JCOMOIDC-66 - Review ProfileConfiguration interfaces and concrete
    classes
    
     - Update config to use new concrete profile configuration classes
     - Move JWK credential factories
    
    https://shibboleth.atlassian.net/browse/JCOMOIDC-66
---
 .gitignore                                                         | 1 +
 .../src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml  | 4 ++--
 .../net/shibboleth/idp/service/relying-party/postconfig.xml        | 7 ++++---
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/.gitignore b/.gitignore
index 5615e47..12bfa79 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,5 @@
 .classpath
+*/bin
 .DS_Store
 */target
 */test-output
diff --git a/oidc-config-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml b/oidc-config-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
index 245a048..b2ca4eb 100644
--- a/oidc-config-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
+++ b/oidc-config-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
@@ -13,10 +13,10 @@
     
     <!-- Credential bean factories -->
     <bean id="shibboleth.oidc.ClientSecretCredential" abstract="true"
-        class="net.shibboleth.oidc.security.credential.impl.BasicClientSecretCredentialFactoryBean" />    
+        class="net.shibboleth.oidc.security.credential.BasicClientSecretCredentialFactoryBean" />    
         
     <bean id="shibboleth.oidc.JWKCredential" abstract="true"
-        class="net.shibboleth.oidc.security.credential.impl.BasicJWKCredentialFactoryBean" />
+        class="net.shibboleth.oidc.security.credential.BasicJWKCredentialFactoryBean" />
     
     <!-- Singleton JWK cache -->
     <bean id="shibboleth.oidc.RemoteJwkSetCache"
diff --git a/oidc-config-impl/src/main/resources/META-INF/net/shibboleth/idp/service/relying-party/postconfig.xml b/oidc-config-impl/src/main/resources/META-INF/net/shibboleth/idp/service/relying-party/postconfig.xml
index 7a9ba64..394799c 100644
--- a/oidc-config-impl/src/main/resources/META-INF/net/shibboleth/idp/service/relying-party/postconfig.xml
+++ b/oidc-config-impl/src/main/resources/META-INF/net/shibboleth/idp/service/relying-party/postconfig.xml
@@ -49,12 +49,11 @@
         p:refreshTokenLifetime="%{idp.oidc.refreshToken.defaultLifetime:PT2H}"
         p:alwaysIncludedAttributes="%{idp.oidc.alwaysIncludedAttributes:}"        
         p:tokenEndpointAuthMethod="%{idp.authn.oidc.rp.client.authenticationMethod:client_secret_basic}"
-        p:responseMode="%{idp.authn.oidc.rp.client.responseMode:#{null}}"
         p:clientId="#{%{idp.authn.oidc.rp.provider.discoveryRequired:false} == true ? null : '%{idp.authn.oidc.rp.client.clientId:}'}"
         p:clientCredential="#{%{idp.authn.oidc.rp.provider.discoveryRequired:false} == true ? {null} : getObject('shibboleth.authn.oidc.rp.DefaultCredential')}"/>
 
    <bean id="OIDC.SSO" parent="AbstractOIDCSSOProfile" lazy-init="true"
-        class="net.shibboleth.oidc.profile.config.OIDCAuthorizationConfiguration"        
+        class="net.shibboleth.oidc.profile.config.impl.DefaultOIDCAuthorizationConfiguration"        
         p:authorizeCodeLifetime="%{idp.oidc.authorizeCode.defaultLifetime:PT5M}"
         p:encodeConsentInTokens="%{idp.oidc.encodeConsentInTokens:false}"
         p:encodedAttributes="%{idp.oidc.encodedAttributes:%{idp.oidc.embeddedAttributes:}}"
@@ -65,6 +64,8 @@
         p:encryptRequestObject="%{idp.authn.oidc.rp.client.requestobject.encrypted:false}"
         p:signRequestObject="%{idp.authn.oidc.rp.client.requestobject.signed:true}"
         p:useRequestObject="%{idp.authn.oidc.rp.client.requestobject.supported:false}"
+        p:responseMode="%{idp.authn.oidc.rp.client.responseMode:#{null}}"
+        p:tlsServerValidationSufficient="%{idp.authn.oidc.rp.client.idtoken.tlsServerValidationOnly:false}"
         p:userInfoHttpRequestMethod="%{idp.authn.oidc.rp.client.userinfo.httpRequestMethod:GET}"
         p:scopes="%{idp.authn.oidc.rp.client.scopes:#{null}}">
         <property name="forceAuthnPredicate">
@@ -97,7 +98,7 @@
     
     <!-- Keyset profile -->
     <bean id="OIDC.Keyset" parent="AbstractOIDCProfile" lazy-init="true"
-        class="net.shibboleth.oidc.profile.config.OIDCPublishKeySetConfiguration"
+        class="net.shibboleth.oidc.profile.config.impl.DefaultOIDCPublishKeySetConfiguration"
         p:securityConfiguration-ref="shibboleth.oidc.PublishKeySetSecurityConfiguration" />
         
      <!--  Configuration for publishing key set. -->

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list