[JIRA] (JCOMOIDC-66) Review ProfileConfiguration interfaces and concrete classes

Philip Smart (Jira) jira at shibboleth.atlassian.net
Wed Apr 19 13:34:52 UTC 2023


Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JCOMOIDC-66 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66?atlOrigin=eyJpIjoiZWUyYzMyNzAwY2E4NDcxYmFlMDgwN2I4MTc2NzNlMDMiLCJwIjoiaiJ9 )

Re: Review ProfileConfiguration interfaces and concrete classes ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66?atlOrigin=eyJpIjoiZWUyYzMyNzAwY2E4NDcxYmFlMDgwN2I4MTc2NzNlMDMiLCJwIjoiaiJ9 )

Having reviewed with Henri, I’ve moved three of the RP-specific client auth methods into a separate interface as the OP would never use them. I also inherited the PKCE methods into the RP interface. OP compiles and tests OK, and so does the RP (although RP can change, so less relevant). I think it is now ready to merge.

( https://shibboleth.atlassian.net/browse/JCOMOIDC-66#add-comment?atlOrigin=eyJpIjoiZWUyYzMyNzAwY2E4NDcxYmFlMDgwN2I4MTc2NzNlMDMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66#add-comment?atlOrigin=eyJpIjoiZWUyYzMyNzAwY2E4NDcxYmFlMDgwN2I4MTc2NzNlMDMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100222- sha1:cb3bdf0 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230419/147d4ca7/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-ea61f704-eb10-4e0e-9d07-5f33f80c3e51
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230419/147d4ca7/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-110e69f3-998a-477c-ba9e-552a78a2e50b
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230419/147d4ca7/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-71a47657-2820-43f6-b3ff-2aa0af3d372a
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230419/147d4ca7/attachment-0005.png>


More information about the commits mailing list