[JIRA] (JSSH-26) Documentation bug on AttributeSupport.getAttributeValueAsBoolean?

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSSH-26 ( https://shibboleth.atlassian.net/browse/JSSH-26?atlOrigin=eyJpIjoiMDRjNTljZWZlMGQyNDg3ZTk2Njc0NWI1ZTRjNDc1ZDQiLCJwIjoiaiJ9 )

Re: Documentation bug on AttributeSupport.getAttributeValueAsBoolean? ( https://shibboleth.atlassian.net/browse/JSSH-26?atlOrigin=eyJpIjoiMDRjNTljZWZlMGQyNDg3ZTk2Njc0NWI1ZTRjNDc1ZDQiLCJwIjoiaiJ9 )

Yes, this is arrant nonsense (and looks like a cut and paste issue).

I have added some words to the javadoc about not using this in a Spring context unless you have to,

> 
> 
> 
> you have to use a factory bean for booleans, right?
> 
> 

Or inject the string into a boolean setter, then property replacement will happen before type massaging. Our native spring files use this all over the shop.

( https://shibboleth.atlassian.net/browse/JSSH-26#add-comment?atlOrigin=eyJpIjoiMDRjNTljZWZlMGQyNDg3ZTk2Njc0NWI1ZTRjNDc1ZDQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-26#add-comment?atlOrigin=eyJpIjoiMDRjNTljZWZlMGQyNDg3ZTk2Njc0NWI1ZTRjNDc1ZDQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100222- sha1:cb3bdf0 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230419/5d64fba5/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-6ffa555c-0ad9-4a95-8a84-13f66f858370
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230419/5d64fba5/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-0e2451c4-d139-4ae3-b089-fd6bc2e50b5f
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230419/5d64fba5/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-58082007-9599-4b1b-aab9-ccd1d93b8398
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230419/5d64fba5/attachment-0005.png>