[java-shib-shared] branch main updated: JSSH-26 Documentation bug on AttributeSupport.getAttributeValueAsBoolean?

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-shared.git;a=commit;h=ad33874bfe7e5d59bf61838049f5558535024a61

The following commit(s) were added to refs/heads/main by this push:
     new ad33874b JSSH-26 Documentation bug on AttributeSupport.getAttributeValueAsBoolean?
ad33874b is described below

commit ad33874bfe7e5d59bf61838049f5558535024a61
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Wed Apr 19 11:09:15 2023 +0100

    JSSH-26 Documentation bug on AttributeSupport.getAttributeValueAsBoolean?
    
    https://shibboleth.atlassian.net/browse/JSSH-26
---
 .../src/main/java/net/shibboleth/shared/xml/AttributeSupport.java      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/shib-support/src/main/java/net/shibboleth/shared/xml/AttributeSupport.java b/shib-support/src/main/java/net/shibboleth/shared/xml/AttributeSupport.java
index a4de1bb3..66accebf 100644
--- a/shib-support/src/main/java/net/shibboleth/shared/xml/AttributeSupport.java
+++ b/shib-support/src/main/java/net/shibboleth/shared/xml/AttributeSupport.java
@@ -317,11 +317,12 @@ public final class AttributeSupport {
     /**
      * Parses the attribute's value. If the value is 0 or "false" then false is returned, if the value is 1 or "true"
      * then true is returned, if the value is anything else then null returned.
+     * <p><em> Note</em> that in a Spring context this is not usually useful since you are looking at values
+     * prior to property replacement.  Injecting a string into a boolean setter will usually "do the right thing".</p>
      * 
      * @param attribute attribute whose value will be converted to a boolean
      * 
      * @return boolean value of the attribute or null
-     * late enough to allow property replacement.
      */
     @Nullable public static Boolean getAttributeValueAsBoolean(@Nonnull final Attr attribute) {
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.