[JIRA] (JCOMOIDC-66) Review ProfileConfiguration interfaces and concrete classes

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JCOMOIDC-66 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66?atlOrigin=eyJpIjoiOTg2NjkyNjk4YWZlNDY4ODliNGI3NzE3YzY0N2Y0ZTYiLCJwIjoiaiJ9 )

Re: Review ProfileConfiguration interfaces and concrete classes ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66?atlOrigin=eyJpIjoiOTg2NjkyNjk4YWZlNDY4ODliNGI3NzE3YzY0N2Y0ZTYiLCJwIjoiaiJ9 )

Review notes:

* Eventually I want to get all of the interfaces ending in ProfileConf
* Should OIDCTokenEncryptionProfileConfiguration be OAuth2Token… and be moved to the oauth2 package? Not sure it existed before this redesign?

As a whole I think it’s fine. Ultimately I would just do a final review of each concrete profile and look at all the settings they expose. If they seem to be the right set and nothing is somehow non-functional due to never being used for that profile, then it’s probably correct.

Of course we do need to wire in metadata lookup support into MDDriven versions of all the profiles, which may take some doing.

( https://shibboleth.atlassian.net/browse/JCOMOIDC-66#add-comment?atlOrigin=eyJpIjoiOTg2NjkyNjk4YWZlNDY4ODliNGI3NzE3YzY0N2Y0ZTYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66#add-comment?atlOrigin=eyJpIjoiOTg2NjkyNjk4YWZlNDY4ODliNGI3NzE3YzY0N2Y0ZTYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:d40a829 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230417/b16ec980/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-5317bd72-6e96-48bb-87c9-a97bbb84143c
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230417/b16ec980/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-503abdfc-c3b3-4ea9-97d0-b27caad49055
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230417/b16ec980/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-4a9e785f-a2c5-47f7-b552-3984d81bd119
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230417/b16ec980/attachment-0005.png>