[java-idp-oidc] 03/03: Exploit activation condition for signature params population.

Henri Mikkonen henri.mikkonen at iki.fi
Thu Apr 6 13:04:45 UTC 2023


This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=836fb72d64da905aea7893970bb2a6b268f10ae7

commit 836fb72d64da905aea7893970bb2a6b268f10ae7
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Thu Apr 6 16:02:58 2023 +0300

    Exploit activation condition for signature params population.
    
    Only resolve the signing parameters if SignUserInfoResponseCondition is true,
    otherwise the SWF action may cause unnecessary log noise.
---
 .../net/shibboleth/idp/flows/oidc/userinfo/userinfo-beans.xml       | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/userinfo/userinfo-beans.xml b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/userinfo/userinfo-beans.xml
index 346b99fd..7e7fccdc 100644
--- a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/userinfo/userinfo-beans.xml
+++ b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/userinfo/userinfo-beans.xml
@@ -74,11 +74,9 @@
         class="net.shibboleth.oidc.profile.impl.PopulateJWTSignatureSigningParameters" scope="prototype"
         c:strategy-ref="shibboleth.MessageContextLookup.Inbound"
         p:configurationLookupStrategy-ref="JWTSignatureSigningConfigurationLookupFunction"
-        p:signatureSigningParametersResolver-ref="shibboleth.oidc.UserInfoSignatureSigningParametersResolver">
+        p:signatureSigningParametersResolver-ref="shibboleth.oidc.UserInfoSignatureSigningParametersResolver"
+        p:activationCondition-ref="SignUserInfoResponseCondition">
         <property name="securityParametersContextLookupStrategy">
-<!--             <bean parent="shibboleth.Functions.Compose"
-                c:g-ref="shibboleth.oidc.ChildLookupOrCreate.JWTSecurityParameters"
-                c:f-ref="shibboleth.ChildLookup.RelyingParty" />-->
             <bean parent="shibboleth.Functions.Compose"
                 c:g-ref="shibboleth.oidc.ChildLookupOrCreate.JWTSecurityParameters"
                 c:f-ref="shibboleth.MessageContextLookup.Outbound" />

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list