[JIRA] (MDA-282) Add progress logging for CompositeStage and SimplePipeline

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on MDA-282 ( https://shibboleth.atlassian.net/browse/MDA-282?atlOrigin=eyJpIjoiODc3MGRjNzdjZDYzNGZjMGEyNWM1YmRkYWQwY2I1OGQiLCJwIjoiaiJ9 )

Re: Add progress logging for CompositeStage and SimplePipeline ( https://shibboleth.atlassian.net/browse/MDA-282?atlOrigin=eyJpIjoiODc3MGRjNzdjZDYzNGZjMGEyNWM1YmRkYWQwY2I1OGQiLCJwIjoiaiJ9 )

Done, commit 00cddc22fc7a1904935c98892f5b4357bb879ac8.

SimplePipeline is an empty subclass of CompositeStage , now, so there’s no work required there; everything is in CompositeStage.

As well as a per-instance property enabling this behaviour, the class enables it for all instances if the system property net.shibboleth.metadata.loggingAllProgress is set to true.

Scott suggested another route to controlling this more global enabling would be to include something like this in the parent bean:

p:logProgress="${mda.logAllProgress:false}"

I think this ends up addressing slightly different use cases, and also depends on people using the (new in this release) standard bean definition resource. There’s also the issue of whether placeholders get replaced correctly in all environments (the above would not, for example, work correctly in the IdP environment, where the placeholders need to be {{%

{...}}} instead of {{${...}

}}. All considered, I’m going to leave that in the back of my mind as a possible future addition if it looks like it’s needed later.

( https://shibboleth.atlassian.net/browse/MDA-282#add-comment?atlOrigin=eyJpIjoiODc3MGRjNzdjZDYzNGZjMGEyNWM1YmRkYWQwY2I1OGQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-282#add-comment?atlOrigin=eyJpIjoiODc3MGRjNzdjZDYzNGZjMGEyNWM1YmRkYWQwY2I1OGQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:d541bce )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230403/e7f38066/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e312ed05-d415-4108-8619-f08cb9ba4e60
Type: image/png
Size: 302 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230403/e7f38066/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-e8bf0576-6e45-43a0-bfcc-8d1d29f89e6b
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230403/e7f38066/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-302e4e0e-e0fc-47c9-88f5-219ffbbdfea0
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230403/e7f38066/attachment-0005.png>