[JIRA] (JSSH-9) Rework IdentifierGenerationStrategy usage

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Shibboleth Shared - Java ( https://shibboleth.atlassian.net/browse/JSSH?atlOrigin=eyJpIjoiNDE5MjAyODRkNjEyNGRmMzhhNzhhZTZlNWFlNjI1NWQiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/JSSH-9?atlOrigin=eyJpIjoiNDE5MjAyODRkNjEyNGRmMzhhNzhhZTZlNWFlNjI1NWQiLCJwIjoiaiJ9 ) JSSH-9 ( https://shibboleth.atlassian.net/browse/JSSH-9?atlOrigin=eyJpIjoiNDE5MjAyODRkNjEyNGRmMzhhNzhhZTZlNWFlNjI1NWQiLCJwIjoiaiJ9 ) Rework IdentifierGenerationStrategy usage ( https://shibboleth.atlassian.net/browse/JSSH-9?atlOrigin=eyJpIjoiNDE5MjAyODRkNjEyNGRmMzhhNzhhZTZlNWFlNjI1NWQiLCJwIjoiaiJ9 )

Issue Type: Improvement Assignee: Unassigned Components: Security Created: 26/Sep/22 10:11 AM Fix Versions: 9.0.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

I’m not a big fan of how we’re using the IdentifierGenerationStrategy interface since we seem to just hardwire references to one of the 2-3 implementations we have all over the code base. It feels like we should either make those concrete classes the actual API or change things to support more of an abstraction layer somehow.

I could imagine going all out and creating some kind of “criterion” approach to this where the requirements for the identifier would be supplied to the API and then it would sort out which actual implementation to use based on that. But I’m not sure the overhead is worth it.

If nothing else, I suspect we need to adjust a few places where the code doesn’t really expose the ability to override the interface implementation used by a class, which I think I spotted in a few cases.

( https://shibboleth.atlassian.net/browse/JSSH-9#add-comment?atlOrigin=eyJpIjoiNDE5MjAyODRkNjEyNGRmMzhhNzhhZTZlNWFlNjI1NWQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-9#add-comment?atlOrigin=eyJpIjoiNDE5MjAyODRkNjEyNGRmMzhhNzhhZTZlNWFlNjI1NWQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:1c92a42 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220926/59c784b6/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-0d5ea33f-4d91-4b6d-89a4-456f1fd51aec
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220926/59c784b6/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-616053d7-6215-4981-8564-7694f1d68aee
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220926/59c784b6/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-6f72cef6-ab51-44f1-a436-fb4a8e7a4e39
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220926/59c784b6/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-75ba4336-3eb5-4a83-ad18-a6436a5331d6
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220926/59c784b6/attachment-0007.png>