[JIRA] (IDP-1972) Revisit deferred classnames for solving layering conflicts

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-1972 ( https://shibboleth.atlassian.net/browse/IDP-1972?atlOrigin=eyJpIjoiMjEzYjM4YzhkZmFlNDQ2ZGJlZWU4Njg5OGRhOWYxNmUiLCJwIjoiaiJ9 )

Re: Revisit deferred classnames for solving layering conflicts ( https://shibboleth.atlassian.net/browse/IDP-1972?atlOrigin=eyJpIjoiMjEzYjM4YzhkZmFlNDQ2ZGJlZWU4Njg5OGRhOWYxNmUiLCJwIjoiaiJ9 )

> 
> 
> 
> Just confirming I did not use the SecondaryNamespace concept anywhere in
> the end, I used a class instnatiation trick to get the right class
> reference into the parsers.
> 
> 

Having just reviewed the code I can see why this would become “cumbersome”. This is particularly true because of the relyingpartiespredicate which goes in at the very bottom of a huge pile of parsers. I spent about 30 seconds wondering whether “net.shibboleth.idp.profile.logic.RelyingPartyIdPredicate could be moved down (it’s just a predicate to do with metadata)” and ran away screaming when I realized that it very quickly gets very deeply embedded into IdP internals. The other three parsers could be done with SecondaryNameSpace but that RP predicate is the killer and it seems to me that the cleave points used look absolutely correct…

I’m not comfortable leaving the SecondaryNameSpace stuff in place if it isn’t being used (we can always reinvent it)

> 
> 
> 
> I think a possible middle ground would be to load something via a Java
> Service interface to get the right classes to instantiate
> 
> 

Agreed. All code that we don’t write sound like a good plan. Off the top of my head an Interface which extends Function<String, Class<?>> would seem the place to start (iterate over all the providers until you find what you are looking for)

But for now it feels as though things are still moving and it would probably be a good idea to let this lie fallow for a few more weeks (potentially even until the SP starts coming together).

( https://shibboleth.atlassian.net/browse/IDP-1972#add-comment?atlOrigin=eyJpIjoiMjEzYjM4YzhkZmFlNDQ2ZGJlZWU4Njg5OGRhOWYxNmUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1972#add-comment?atlOrigin=eyJpIjoiMjEzYjM4YzhkZmFlNDQ2ZGJlZWU4Njg5OGRhOWYxNmUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:1c92a42 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220926/fc738972/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-0ffcf5a6-8796-4a73-bb39-80b8fc452a70
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220926/fc738972/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-0bcee103-9327-4b66-a227-d02350874115
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220926/fc738972/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-3a62502a-43f1-4cc5-b6ab-2fc583923c49
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220926/fc738972/attachment-0005.png>