[JIRA] (SSPCPP-956) Add "retryErrors" parameter to TCPListener directive

[Paul B. Henson (Jira)]

Paul B. Henson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5b58f937ffd0a32d7917a0df ) *created* an issue

Shibboleth SP - C++ ( https://shibboleth.atlassian.net/browse/SSPCPP?atlOrigin=eyJpIjoiY2I4Njk2NzkyNWNmNGJiMjhkN2I3MTkzNTZkNDkwYWIiLCJwIjoiaiJ9 ) / New Feature ( https://shibboleth.atlassian.net/browse/SSPCPP-956?atlOrigin=eyJpIjoiY2I4Njk2NzkyNWNmNGJiMjhkN2I3MTkzNTZkNDkwYWIiLCJwIjoiaiJ9 ) SSPCPP-956 ( https://shibboleth.atlassian.net/browse/SSPCPP-956?atlOrigin=eyJpIjoiY2I4Njk2NzkyNWNmNGJiMjhkN2I3MTkzNTZkNDkwYWIiLCJwIjoiaiJ9 ) Add "retryErrors" parameter to TCPListener directive ( https://shibboleth.atlassian.net/browse/SSPCPP-956?atlOrigin=eyJpIjoiY2I4Njk2NzkyNWNmNGJiMjhkN2I3MTkzNTZkNDkwYWIiLCJwIjoiaiJ9 )

Issue Type: New Feature Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Attachments: sp-recv-retry-2.patch Components: Remoting Created: 16/Sep/22 9:58 PM Priority: Trivial Reporter: Paul B. Henson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5b58f937ffd0a32d7917a0df )

In an environment where the web server plug-in and shibd are operating on different systems and communicating via TCP across a network it is possible for the initial send to appear to succeed but actually fail and then the attempted receive would fail causing a user visible error. This would typically happen when a load balancer was in between mucking with packets and potentially killing connections without notification, but could also occur in other scenarios.

This patch adds a new "retryErrors" parameter to the TCPListener directive which specifies a list of error codes for which the transaction should be re-attempted. If the receive fails with one of these error codes, the send is tried again which establishes a fresh new connection which will likely succeed.

We have tested this patch in a Windows environment using an Azure load balancer with retryErrors=10060,10054 (connection timed out, connection reset) and it resolved the failures that were seen previously.

( https://shibboleth.atlassian.net/browse/SSPCPP-956#add-comment?atlOrigin=eyJpIjoiY2I4Njk2NzkyNWNmNGJiMjhkN2I3MTkzNTZkNDkwYWIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/SSPCPP-956#add-comment?atlOrigin=eyJpIjoiY2I4Njk2NzkyNWNmNGJiMjhkN2I3MTkzNTZkNDkwYWIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:30c8888 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220917/57e8ecc4/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-1045f8bd-75dc-4e9a-81ce-a06e599f8aa7
Type: image/png
Size: 341 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220917/57e8ecc4/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-836da7ec-e704-4b61-9e93-c349e15dd15d
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220917/57e8ecc4/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-abc28d25-ee71-48f0-b9e4-cdd29527186c
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220917/57e8ecc4/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-3348434d-0c31-4934-af32-c2e9f906bc24
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220917/57e8ecc4/attachment-0007.png>