[JIRA] (IDP-2007) Review configuration for any direct use of API classes in beans

Scott Cantor (Jira) jira at shibboleth.atlassian.net
Mon Sep 12 16:42:08 UTC 2022


Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiMDJjNzdhYmNhNjM2NGJjYzhjMDAyZjBkMzY3N2ViZGQiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/IDP-2007?atlOrigin=eyJpIjoiMDJjNzdhYmNhNjM2NGJjYzhjMDAyZjBkMzY3N2ViZGQiLCJwIjoiaiJ9 ) IDP-2007 ( https://shibboleth.atlassian.net/browse/IDP-2007?atlOrigin=eyJpIjoiMDJjNzdhYmNhNjM2NGJjYzhjMDAyZjBkMzY3N2ViZGQiLCJwIjoiaiJ9 ) Review configuration for any direct use of API classes in beans ( https://shibboleth.atlassian.net/browse/IDP-2007?atlOrigin=eyJpIjoiMDJjNzdhYmNhNjM2NGJjYzhjMDAyZjBkMzY3N2ViZGQiLCJwIjoiaiJ9 )

Issue Type: Improvement Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Components: Configuration Created: 12/Sep/22 12:42 PM Fix Versions: 4.3.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

Refactoring tends to be inhibited by use of classes in bean definitions, even though they’re API classes and meant to be stable. We still occasionally have the desire to refactor or move classes around and this is much harder if we encourage direct use of classes instead of providing parent beansm particularly anywhere we supply factory bean classes since those tend to be more “internal” Spring classes rather than intentional API.

An example is the HTTPResource factory bean, which had it been documented via a parent bean could be moved easily.

( https://shibboleth.atlassian.net/browse/IDP-2007#add-comment?atlOrigin=eyJpIjoiMDJjNzdhYmNhNjM2NGJjYzhjMDAyZjBkMzY3N2ViZGQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2007#add-comment?atlOrigin=eyJpIjoiMDJjNzdhYmNhNjM2NGJjYzhjMDAyZjBkMzY3N2ViZGQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100206- sha1:8e0b99e )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220912/06e1aaaa/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-874c47dc-e118-4297-bf24-5315c3d31d23
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220912/06e1aaaa/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-67404279-0182-4d08-841f-27c48973b48d
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220912/06e1aaaa/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-8407bcab-d9a5-440c-b5a0-549fd9c068d7
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220912/06e1aaaa/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a533d026-8a98-4e7e-a0da-2b523015ef92
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220912/06e1aaaa/attachment-0007.png>


More information about the commits mailing list