[java-idp-oidc] branch main updated: JOIDC-121 - Logging messages for No allowed audiences for client warn => debug

[Henri Mikkonen]

This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=5dbc7afd169c8f7d083f283b12a21f30d57a2075

The following commit(s) were added to refs/heads/main by this push:
     new 5dbc7afd JOIDC-121 - Logging messages for No allowed audiences for client warn => debug
5dbc7afd is described below

commit 5dbc7afd169c8f7d083f283b12a21f30d57a2075
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Fri Sep 9 09:31:57 2022 +0300

    JOIDC-121 - Logging messages for No allowed audiences for client warn => debug
    
    https://shibboleth.atlassian.net/browse/JOIDC-121
    
    Improved the if-clause for WARN-logging to notice empty collections.
---
 .../idp/plugin/oidc/op/oauth2/profile/impl/ValidateAudience.java       | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oauth2/profile/impl/ValidateAudience.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oauth2/profile/impl/ValidateAudience.java
index 7c30d171..64f2505f 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oauth2/profile/impl/ValidateAudience.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oauth2/profile/impl/ValidateAudience.java
@@ -186,7 +186,8 @@ public class ValidateAudience extends AbstractOIDCAuthenticationResponseAction {
 
         if (allowedAudience == null || allowedAudience.isEmpty()) {
             if (allowNone) {
-                if (previouslyGrantedAudience != null || requestedAudience != null) {
+                if ((previouslyGrantedAudience != null && !previouslyGrantedAudience.isEmpty())
+                        || (requestedAudience != null && !requestedAudience.isEmpty())) {
                     log.warn("{} No allowed audiences for client {}, OP will be sole audience", getLogPrefix(),
                             clientId);
                 } else {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.