[java-idp-plugin-oidc-rp] branch main updated: Remove unused classes

Phil Smart philip.smart at jisc.ac.uk
Wed Sep 7 15:10:33 UTC 2022


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=ace7f055b5646a4a3f4ed20c5c881314fc65f904

The following commit(s) were added to refs/heads/main by this push:
     new ace7f05  Remove unused classes
ace7f05 is described below

commit ace7f055b5646a4a3f4ed20c5c881314fc65f904
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Wed Sep 7 16:10:23 2022 +0100

    Remove unused classes
---
 .../rp/storage/ClientAuthenticationDetails.java    | 73 ----------------------
 ...henticationRequestNonceClaimLookupStrategy.java |  3 +-
 2 files changed, 1 insertion(+), 75 deletions(-)

diff --git a/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/storage/ClientAuthenticationDetails.java b/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/storage/ClientAuthenticationDetails.java
deleted file mode 100644
index fa12f6c..0000000
--- a/idp-oidc-rp-api/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/storage/ClientAuthenticationDetails.java
+++ /dev/null
@@ -1,73 +0,0 @@
-package net.shibboleth.idp.plugin.authn.oidc.rp.storage;
-
-import javax.annotation.Nonnull;
-import javax.annotation.concurrent.Immutable;
-
-import com.fasterxml.jackson.annotation.JsonProperty;
-
-import net.shibboleth.utilities.java.support.annotation.ParameterName;
-import net.shibboleth.utilities.java.support.annotation.constraint.NotEmpty;
-import net.shibboleth.utilities.java.support.logic.Constraint;
-
-/** A bean to hold client_authentication registration details.*/
-//TODO: this is not a storage system bean, the json properties are not needed.
-//TODO we no longer use this, remove!
- at Deprecated
- at Immutable
-public class ClientAuthenticationDetails {
-    
-    /** The client secret. */
-    @JsonProperty("client_secret") @Nonnull @NotEmpty private final char[] clientSecret;
-    
-    /** When the client secret expires.*/
-    @JsonProperty("client_secret_expires_at") private final long clientSecretExpiresAt;
-    
-    /** The token endpoint authentication method. */
-    @JsonProperty("token_endpoint_auth_method") @Nonnull @NotEmpty private final String tokenEndpointAuthMethod;
-
-    /**
-     * Constructor.
-     *
-     * @param secret The client secret
-     * @param secretExpiresAt When the client secret expires
-     * @param authMethod
-     */
-    public ClientAuthenticationDetails(@ParameterName(name="clientSecret") @Nonnull final char[] secret, 
-            @ParameterName(name="clientSecretExpiresAt") final long secretExpiresAt,
-            @ParameterName(name="tokenEndpointAuthMethod") @Nonnull @NotEmpty final String authMethod) {
-        super();
-        clientSecret = Constraint.isNotNull(secret, "Secret can not be null");
-        clientSecretExpiresAt = secretExpiresAt;
-        tokenEndpointAuthMethod = Constraint.isNotEmpty(authMethod, "Authentication method can not be null or empty");
-    }
-
-    /**
-     * Get the client_secret. 
-     * 
-     * @return Returns the clientSecret.
-     */
-    @Nonnull public char[] getClientSecret() {
-        return clientSecret;
-    }
-
-    /**
-     * Get when the client secret expires in number of seconds since UNIX EPOCH. 
-     * 
-     * @return Returns the clientSecretExpiresAt.
-     */
-    public long getClientSecretExpiresAt() {
-        return clientSecretExpiresAt;
-    }
-
-    /**
-     * Get the token authentication method.
-     * 
-     * @return Returns the tokenEndpointAuthMethod.
-     */
-    @Nonnull @NotEmpty public String getTokenEndpointAuthMethod() {
-        return tokenEndpointAuthMethod;
-    }
-    
-    
-
-}
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthenticationRequestNonceClaimLookupStrategy.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthenticationRequestNonceClaimLookupStrategy.java
index 7f38e72..c8f3b2b 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthenticationRequestNonceClaimLookupStrategy.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/AuthenticationRequestNonceClaimLookupStrategy.java
@@ -29,12 +29,11 @@ import org.opensaml.profile.context.ProfileRequestContext;
 
 import com.nimbusds.jwt.JWTClaimsSet;
 
-import net.shibboleth.idp.authn.duo.context.DuoAuthenticationContext;
 import net.shibboleth.oidc.profile.core.OIDCAuthenticationRequest;
 import net.shibboleth.utilities.java.support.logic.Constraint;
 
 /** 
- * Find the nonce from the {@link DuoAuthenticationContext}. Returns null if not found.
+ * Find the nonce from the {@link OIDCAuthenticationRequest}. Returns null if not found.
  */
 @ThreadSafe
 public final class AuthenticationRequestNonceClaimLookupStrategy 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list