[JIRA] (JOIDCRP-17) Add JWT Encryption Parameter Resolver Support
Philip Smart (Jira)
jira at shibboleth.atlassian.net
Mon Sep 5 19:01:30 UTC 2022
Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JOIDCRP-17 ( https://shibboleth.atlassian.net/browse/JOIDCRP-17?atlOrigin=eyJpIjoiN2Q3MzYxMjc0ZWIwNGE3MTg1OTM1N2E0ZTIwZjMwNTUiLCJwIjoiaiJ9 )
Re: Add JWT Encryption Parameter Resolver Support ( https://shibboleth.atlassian.net/browse/JOIDCRP-17?atlOrigin=eyJpIjoiN2Q3MzYxMjc0ZWIwNGE3MTg1OTM1N2E0ZTIwZjMwNTUiLCJwIjoiaiJ9 )
I’ve committed the new code (a bit early as not around for a few days). The biggest changes are:
* The BasicJWTEncryptionParametersResolver has now become the DefaultJWTEncryptionParametersResolver. It now contains the overall logic to produce enc parameters (whereas before it did the basics, and relied on sub-types to perform more specific resolution). This is the starting point for review.
* The data encryption and key transport algorithms to use are now supplied as lookup functions.
* The credentials are supplied by credential resolvers which are injected into the encryption config. Much like the decryption config.
* The ProviderMetadataEncryptionParametersResolver has been decomposed and hence removed. The functionality has been split into:
* ProviderMetadataKeyTransportEncryptionAlgorithmsLookupStrategy and ProviderMetadataDataEncryptionAlgorithmsLookupStrategy which extend the base classes DefaultKeyTransportEncryptionAlgorithmsLookupStrategy and DefaultDataEncryptionAlgorithmsLookupStrategy. These just derive the correct algorithms to use from the local config and the OpenID Provider’s metadata.
* Credential resolvers. Although by default it is configured to use the existing CriterionCredentialResolver}}to pull out the client_secret - the only symmetric key allowed - and the slightly modified {{ProviderMetadataCredentialResolver (both you may have seen before) - for asymmetric key lookup.
I think that is about as good as I can make it for now. So it should stay like this for a while.
( https://shibboleth.atlassian.net/browse/JOIDCRP-17#add-comment?atlOrigin=eyJpIjoiN2Q3MzYxMjc0ZWIwNGE3MTg1OTM1N2E0ZTIwZjMwNTUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDCRP-17#add-comment?atlOrigin=eyJpIjoiN2Q3MzYxMjc0ZWIwNGE3MTg1OTM1N2E0ZTIwZjMwNTUiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100206- sha1:3fcec87 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220905/d877575b/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-5e0c70b8-e394-41b0-9fa3-647fb2c180ab
Type: image/png
Size: 341 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220905/d877575b/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-68f7330e-06ff-4b52-a018-0225452e0e2d
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220905/d877575b/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-c13a34a5-a71f-4a8c-9dbd-f274f8bf5a91
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220905/d877575b/attachment-0005.png>
More information about the commits
mailing list