[JIRA] (IDP-2001) Invalid minor version for plugins logged during the IdP startup

Fri Sep 2 10:09:07 UTC 2022

Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiYjYxMjRjNGQwNjc5NGIwODk3MjYxYjk5ZWJmNmNmYzkiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/IDP-2001?atlOrigin=eyJpIjoiYjYxMjRjNGQwNjc5NGIwODk3MjYxYjk5ZWJmNmNmYzkiLCJwIjoiaiJ9 ) IDP-2001 ( https://shibboleth.atlassian.net/browse/IDP-2001?atlOrigin=eyJpIjoiYjYxMjRjNGQwNjc5NGIwODk3MjYxYjk5ZWJmNmNmYzkiLCJwIjoiaiJ9 ) Invalid minor version for plugins logged during the IdP startup ( https://shibboleth.atlassian.net/browse/IDP-2001?atlOrigin=eyJpIjoiYjYxMjRjNGQwNjc5NGIwODk3MjYxYjk5ZWJmNmNmYzkiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 4.2.0, 4.2.1 Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Components: Logging and Metrics Created: 02/Sep/22 6:09 AM Priority: Trivial Reporter: Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd )

Right after logging its own version and Java version, IdP also logs plugin versions on INFO-level to ids-process log during the startup.

However, the minor versions of the plugins are always incorrect, not depending on the plugin. In an example case, OIDC commons 2.1.0, OP 3.2.1 and JDBC 1.0.4 plugins are installed but the following lines are logged:

2022-09-02 09:27:55,268 -  - INFO [net.shibboleth.idp.log.LogbackLoggingService:245] - Shibboleth IdP Version 4.2.0
2022-09-02 09:27:55,271 -  - INFO [net.shibboleth.idp.log.LogbackLoggingService:246] - Java version='11.0.6' vendor='Amazon.com Inc.'
2022-09-02 09:27:55,313 -  - INFO [net.shibboleth.idp.log.LogbackLoggingService:261] - Plugins:
2022-09-02 09:27:55,313 -  - INFO [net.shibboleth.idp.log.LogbackLoggingService:263] - 		net.shibboleth.idp.plugin.oidc.op : v3.3.2
2022-09-02 09:27:55,314 -  - INFO [net.shibboleth.idp.log.LogbackLoggingService:263] - 		net.shibboleth.plugin.storage.jdbc : v1.1.4
2022-09-02 09:27:55,314 -  - INFO [net.shibboleth.idp.log.LogbackLoggingService:263] - 		net.shibboleth.oidc.common : v2.2.0

The plugin CLI tool displays the versions correctly:

sh bin/plugin.sh -l
INFO  - Including auto-located properties in bin/../conf/authn/authn.properties
INFO  - Including auto-located properties in bin/../conf/services.properties
INFO  - Including auto-located properties in bin/../conf/admin/admin.properties
INFO  - Including auto-located properties in bin/../conf/oidc.properties
INFO  - Including auto-located properties in bin/../conf/c14n/subject-c14n.properties
INFO  - Including auto-located properties in bin/../conf/ldap.properties
INFO  - Including auto-located properties in bin/../conf/saml-nameid.properties
WARN  - Ignoring duplicate property 'idp.authn.LDAP.bindDNCredential'
Plugin: net.shibboleth.idp.plugin.oidc.op	Current Version: 3.2.1
Plugin: net.shibboleth.plugin.storage.jdbc	Current Version: 1.0.4
Plugin: net.shibboleth.oidc.common	Current Version: 2.1.0

After reviewing the code, this is caused by the fact that *LogbackLoggingService* is logging the major version in the place of the minor:

    ...
           logger.info("Plugins:");
           for (final IdPPlugin idpPlugin : plugins) {
                logger.info("\t\t{} : v{}.{}.{}",  idpPlugin.getPluginId(), idpPlugin.getMajorVersion(),
                       idpPlugin.getMajorVersion(), idpPlugin.getPatchVersion());
   ...

( https://shibboleth.atlassian.net/browse/IDP-2001#add-comment?atlOrigin=eyJpIjoiYjYxMjRjNGQwNjc5NGIwODk3MjYxYjk5ZWJmNmNmYzkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2001#add-comment?atlOrigin=eyJpIjoiYjYxMjRjNGQwNjc5NGIwODk3MjYxYjk5ZWJmNmNmYzkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100206- sha1:3ac329d )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220902/6f5a10a3/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-1cef4a11-be2b-4f11-a03e-d72dde12b188
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220902/6f5a10a3/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-7190a990-d1d1-445b-9e2e-de8acb2022f6
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220902/6f5a10a3/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-b32e3086-0414-4cdc-83c8-8e6c8ec59bc2
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220902/6f5a10a3/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-fa56ecb1-9f9c-426f-b0b3-cfff31e8c678
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220902/6f5a10a3/attachment-0007.png>